Jan Wassenberg

Results 405 comments of Jan Wassenberg

Please clarify what you would like to happen, and what steps you have tried with what result :)

Looks good to me as well, thanks for adding the StaticCast :) Just one more small suggestion, then we're good to go. Or let me know if you'd prefer we...

+1, we'd welcome a pull request for this, also happy to discuss.

Nice, sounds great, we'd be happy to collaborate with you, discuss and review :) FYI the KVCache internals will likely change a bit to use RowVectorBatch at some point, but...

Hi, you can build with `-DPROFILER_ENABLED=1`, then use %q at the prompt to quit, and we print the results to stdout.

The renumbering is done, and thanks @johnplatts for adding the Apple detection :)

Hi, I'm not seeing a diff here. What would you like to update?

Thanks for letting us know. Unfortunately RVV tests in our CI are currently disabled because the toolchain is crashing. We've filed an LLVM bug:)

Meanwhile, LLVM has rolled back the patch that caused the compiler crash. Our RVV tests are again usable. Would you like to file an LLVM issue for the test failure...

Interesting, thanks for checking. Our toolchain doesn't come with an exact version, but it is relatively close to LLVM HEAD. It seems to succeed with -march=rv64gcv1p0. What build flags are...