gemma.cpp icon indicating copy to clipboard operation
gemma.cpp copied to clipboard

Published 20 hours ago • verified publisher icon google

Add clang-tidy, fix narrowing issues, fix constness

Open enum-class opened this issue 11 months ago • 2 comments

  • introduce clang-tidy into codebase
  • rectify narrowing issues by adjusting type conversions appropriately to prevent potential data loss or undefined behavior
  • Review the codebase to identify areas where const correctness can be improved.

unfortunately I did not find tests in repo to check.

enum-class avatar Feb 28 '24 12:02 enum-class

This looks pretty good. @jan-wassenberg if this looks alright to you we can probably go ahead and merge.

austinvhuang avatar Mar 01 '24 15:03 austinvhuang

Looks good to me as well, thanks for adding the StaticCast :) Just one more small suggestion, then we're good to go. Or let me know if you'd prefer we make this change.

jan-wassenberg avatar Mar 02 '24 04:03 jan-wassenberg