jamshale

Results 217 comments of jamshale

I agree with pretty much all the points here, except a couple small points: - the seed parameter will work for a did:indy type did that was created with the...

If you have multiple local dids, you can tell it which one to use as the public did with the seed when starting up. So you could create a did:sov...

I don't really think the --seed parameter should be used, but I'm not really sure of the history of it. I think that's what that ticket https://github.com/openwallet-foundation/acapy/issues/3240 is trying to...

The public did concept does need to be discussed. My goal here was to maintain the same process as did:sov, but I do agree with your points. The did registration...

I'm going to update this and try and get it merged. I think this one did:indy method could be added to the core for now. Eventually removed with the other...

I'm reopening this as there was another request to get it included in acapy. Allows the creation of did:indy did's which are generated with a slightly different algorithm then did:sov's....

Changed quite a few other error responses in wallet routes to BadRequest. I agree Forbidden didn't make sense for almost all of them.

Sounds good. I reverted the other error responses other than the one I added in this PR. Will create separate issue to review the Forbidden responses.

I'll go over this wallet startup stuff again. I was intending to refactor it without changing any behavior. But from the comments there is still some improvements that should be...

I'm still on vacation until Wednesday. I thought this error was when the did doesn't have an endpoint associated with it. I don't know why the did:indy stuff would have...