James Pratt

Neither does this work: https://github.com/jointprob/jointprob-shadow-cljs/commit/042c5934573b2b8543bc70263ab798b7807811e8

I experimented with using the "componentWillUnmount" as suggested in the clojureverse thread hook but it is not called when vegaEmbed replaces one graph with another. I did eventually find the...

There is a react-vega component maintained as part of the vega project that recompiles a changed spec or uses view.change when only the data changes: https://github.com/vega/react-vega/blob/master/packages/react-vega/src/utils/updateSingleDatasetInView.ts

Discussing with jsa-aerial, Hanami maintainer, here: https://clojurians.zulipchat.com/#narrow/stream/210075-saite-dev/topic/animated.20vega-lite.20graphs/near/303463351

@Jeiwan that might not be safe? Some of the readers in `*data-readers* ` apparently use eval. See comment here: https://clojuredocs.org/clojure.edn/read

Hanami expects it: https://github.com/jsa-aerial/hanami/commit/881a2e459cbfbd8752e0b6683cd2a03fecde7da3 It seems like actually there was a change in the vega-lite library at some point from vl to vegaLite.

I'll file a new pull request, hang on.

> Note that you can just do this in your own code. Doing this in shadow-cljsjs really isn't required. I made the suggested change to the pull request. This might...