shadow-cljsjs icon indicating copy to clipboard operation
shadow-cljsjs copied to clipboard

vegaLite not vl for symbol name

Open jamiepratt opened this issue 3 years ago • 6 comments

I believe that vegaLite is the correct symbol name not vl.

jamiepratt avatar Oct 21 '22 10:10 jamiepratt

Which CLJS library expects this? If you are using this in your own code you should require this directly and now use cljsjs shims.

thheller avatar Oct 21 '22 11:10 thheller

Hanami expects it:

https://github.com/jsa-aerial/hanami/commit/881a2e459cbfbd8752e0b6683cd2a03fecde7da3

It seems like actually there was a change in the vega-lite library at some point from vl to vegaLite.

jamiepratt avatar Oct 21 '22 11:10 jamiepratt

I do not know if there is any other library out there using vl, so the only reasonable thing to do here is to export both.

thheller avatar Oct 21 '22 11:10 thheller

I'll file a new pull request, hang on.

jamiepratt avatar Oct 21 '22 11:10 jamiepratt

Note that you can just do this in your own code. Doing this in shadow-cljsjs really isn't required.

thheller avatar Oct 21 '22 11:10 thheller

Note that you can just do this in your own code. Doing this in shadow-cljsjs really isn't required.

I made the suggested change to the pull request. This might affect other libraries that will now be expecting the 'vegaLite' symbol to be available from the latest cljsjs library so perhaps it makes sense to make the change in this repo.

jamiepratt avatar Oct 21 '22 11:10 jamiepratt