Jamie McCarthy
Jamie McCarthy
Let me know if there are any questions I can answer about this PR, or if you need me to squash commits or reformat anything. I merged `main` back in,...
You make two good points! Changing the language somewhat may be a good choice. And now I wonder if the issue could somehow have been building our container image with...
Is there still interest in having this done? It might be a fun holiday/weekend project...
Bumping this request 😁 (My company's app has had this in our CI for some months now, pinned at 0f34496db4d6e42806eb5ee1d8fa2dfbcffe6ddd )
> It does not appear to me that current maintainers of rack-attack are interested in improvements I will note that over on #578 one of the maintainers has been engaging...
Oops! My misunderstanding. Well, I'm not dismayed — @santib I do think your feedback has been helpful! In any case the repo has had 8 PRs merged in October, so...
> any reason why it wouldn't be enough to make use of the period as a proc feature Hi there! Great question! That doesn't work because what it's doing is...
Hi @santib , thanks for your interest in this and your thoughtful comments! Sorry I didn't get a chance to respond until this week. I'll reply one point at a...
> 2. Move owner of the offset feature + remove use_offset param I have no problem with that, but I'd want to see how it would be done. I wasn't...
> 3. Thread-safety issue Yikes, you're right, good catch! Our app uses Unicorn so I'm embarrassed to say I never even thought of this. Your solution looks great to me,...