Jamie McCarthy
Jamie McCarthy
> I have a diff here just in case it's easier https://github.com/rack/rack-attack/compare/main...santib:rack-attack:jm-random-period-offset. Let me know your thoughts :) Hey yeah that looks great. You're right about just adding an `offset`...
> Let me know your thoughts All that sounds fine. I'm happy to make this PR into the MVP and then look at other changes in later PRs. Want me...
Hey, I just wanted to say I haven't forgotten about this, I've just gotten busy this past week or two. I'll get on this soon, I hope.
Hi Santiago, thanks for the mention. I'll reply on that PR. I haven't forgotten about trying to make this thread-safe, I've just gotten really busy, sorry about that. I still...
I'm interested in seeing this merge too, and I'm happy to work to try to resolve the merge conflicts if you like.
Sure, I'm happy to take this over 👍
At this point, what would you suggest be done with the "Is Sam Ruby happy" section of RELEASING_RAILS.md?
Ah, I'm sorry, I was looking at the `7-0-stable` branch and missed this. Cheers 😀
Ah, I see the requirement. Thanks for the heads-up, @indirect. It's not in `CONTRIBUTING.md`, it's in the pull request template: https://github.com/actions/starter-workflows/blob/2435e576016b3fdd46574a49126d65bfd0d4872f/.github/pull_request_template.md?plain=1#L53 > This workflow must _only_ use actions that are...
I don't have a strong preference for whether the ruby commands get run with `bundle exec` or as binstubs. This PR runs them with `bundle exec`. I've just pushed #2427...