James Wilson

Results 29 comments of James Wilson

As I just mentioned over on 765, the original code here did not pass HTML_CodeSniffer, but passes the http://wave.webaim.org @jackmoore If you're interested in having this as the definitive solution,...

You're totally right @jerseycheese. Sorry about that -- just sent a fix for that in a2b39f2. Anything else? I suppose I could squash the three commits into one before merge...

Also, @jackmoore: do need me to run the js through a minifier in the PR?

@Enchiridion Thanks for the feedback! > I set all those options to empty strings and use css + symbol font in their place. However this causes all the aria-labels to...

Possibly, this is superseded by #832 from @bramd but a bit of a description that outlines the changes there would be helpful.

I've just created two PRs that address this issue in different ways: #821 - Does the bare minimum. Adds button text to pass both the original HTML_CodeSniffer test reported here...

@bramd, thanks for your additions on top of my #822 PR. I only happened to stumble across it by browsing the list of PRs so I'm leaving a comment here...

I use this configuration: ``` new GitRevisionPlugin({ branch: true, versionCommand: "describe --tags --always --dirty | sed -En 's/-dirty/~/p'", branchCommand: "describe --tags --exact-match 2> /dev/null || git symbolic-ref -q --short HEAD...

The complete error message in JS console is: ``` Access to XMLHttpRequest at 'https://docs.google.com/forms/d/e/xxxx/formResponse' from origin 'https://test-cors.org' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the...

```bash cd path/to/project wget https://raw.githubusercontent.com/jsdevel/google-form/master/google-form.js ``` Then add the following to the bottom of your HTML: ```html ```