colorbox icon indicating copy to clipboard operation
colorbox copied to clipboard

Accessibility improvements

Open bramd opened this issue 7 years ago • 3 comments

This PR is based on earlier accessibility related workd by @jameswilson and adds the following:

  • Reworked focus trapping: now the dialog itself isn't focusable and tab/shift+tab cycles through the elements in the dialog
  • ARIA live regions are used to announce changes in the title and the dialog content

bramd avatar Jun 27 '17 13:06 bramd

Hope this gets pulled soon. But project looks dead :( No new releases since 2016/05/10

regularlabs avatar Feb 06 '18 08:02 regularlabs

@bramd, thanks for your additions on top of my #822 PR. I only happened to stumble across it by browsing the list of PRs so I'm leaving a comment here with a mention of my PR in order to link the two.

Would you mind to add an issue description to summarize the additions you've done on top of mine?

Thanks!

jameswilson avatar Feb 07 '18 00:02 jameswilson

@jameswilson commented on Feb 7, 2018, 1:26 AM GMT+1:

Would you mind to add an issue description to summarize the additions you've done on top of mine?

Done. This description is based on a quick look at the commits I did, so I may have missed a few minor changes in the description.

bramd avatar Feb 07 '18 19:02 bramd