James Talmage

Results 145 comments of James Talmage

Bump! I would also appreciate hearing your thoughts on this. Relevant: https://youtu.be/1w_W5cd8qRE?t=27m9s (Javascript Air Episode on Babel)

Note that the discussion in #84 suggested a `length` property to determine the number of parameters, but that is already defined (and not configurable) for Functions. It would be possible...

Some further explanation: https://github.com/benjamn/recast/issues/159#issuecomment-76054246

> Just be careful you don't call this.visit on the same path you just visited, since that will lead to infinite recursion. That is actually what I just did about...

> You wouldn't typically instrument test files though. Good point. > It strikes me though that translating coverage is always going to be flawed. I think you are right.

One downside with piping vs inherit: You lose the `tty` support. We fake `tty` for forked processes in AVA. We could reimplement that for `execa`, but it involves some magic...

There is [`pty.js`](https://www.npmjs.com/package/pty.js) - I've used it before and it works. It's got a native component though. Maybe we could try incorporating that as an optional/peer dependency. If they try...

I just made `is-file-stream`. https://github.com/jamestalmage/is-file-stream

Basically, they only allow streams that have file descriptors, and under the hood, they convert streams to those file descriptors. It would have been way less confusing for them **not**...