jamesob

Concept ACK, will test soon

ACK https://github.com/bitcoin/bitcoin/pull/29215/commits/931575418e082af37b88b1819125b0d0f0fabbd5 Tested locally. Thanks, stackman!

Nice, ACK https://github.com/bitcoin/bitcoin/pull/29204/commits/016cc807f77a9128d430a0df1edd133521628a33

I've reverted to the dumb fix that will unbreak CI (but still add @Sjors' useful coverage for non-Windows platforms). If anyone can come up with something smarter that actually works,...

> Left an alternative suggestion here that (hopefully) doesn't require an exception for Windows: https://github.com/bitcoin/bitcoin/pull/28838/files#r1450778587 Sadly (per the thread), not so simple. I think we should probably unbreak and then...

Closing in favor of https://github.com/bitcoin/bitcoin/pull/29243.

> This can easily lead to OOM Wonder if it's worth warning/failing if the dbcache param exceeds available memory.

Big Concept ACK. `error()` confuses me basically every time I run into it.

Huh, any clue as to why this only becomes an issue on Windows?

ACK https://github.com/bitcoin/bitcoin/pull/29243/commits/ea2551e55d260854a5cca8aa95034970d4adca1c CI is happy.