jamesob
jamesob
There was a bug in here, though I certainly don't think I would have caught it: https://github.com/bitcoin/bitcoin/pull/26477
@theStack thanks; that change accidentally made its way into the wrong commit. Fixed (no change in the resulting code at branch tip).
Trivial rebase pushed. Given the number of (tested) ACKs here it would be nice to get this merged sooner rather than later; it's been open almost a year.
Unless there are any correctness problems I'm going to leave this PR as-is; 3 solid ACKs, so would be nice to get this merged.
Faster, less code, less complexity... seems like a great change to me.
@cthu1hoo for what it's worth, this patch makes things somewhat more bearable: https://github.com/containers/podman-compose/pull/557
Hey, sorry for the egregious delay here and thank you for the reminder. Looks good, thanks!
The included test fails for me when I run it locally with `make bash`: ```sh desktester@1b19b608cca5:~$ bash run_tests.sh Desk dir already exists at /home/desktester/.desk mkdir: cannot create directory '/home/desktester/terraform-repo': File...
Yeah, and there's certainly a usecase for `desk reload` (after you've `desk edit`ed something and want to incorporate the changes into a current shell session). One snag here is that...
Yeah, I'm definitely interested in supporting something complementary at desk's layer. Thanks for the detailed write-up of your thoughts. I've been drafting a behavior to facilitate easy sharing of project-specfic...