jamesob

Actually this _is_ broken at the moment, since although we don't flush after snapshot load, we do flush (and not sync) in the MaybeRebalanceCaches() -> FlushStateToDisk() call right after activating...

> Any plans for a vault() descriptor? That'd be great, though if no one else wants to do that work I'll have spend some time learning more about descriptors. >...

Closing this until the BIP is finalized and this has been tested on inquisition (https://github.com/bitcoin-inquisition/bitcoin/pull/21).

re-ACK https://github.com/bitcoin/bitcoin/pull/27011/commits/561848aaf2d67791e92754f3d11813bc53959a8f

Cool, this is a great thing to investigate. I'll be giving the approach a look this week.

Pushed three additional commits to my branch that may make a dent in the CI issues: - make `fs::path` hashable: https://github.com/jamesob/bitcoin/commit/8f5fdf8ad3d5102e4afaae415e004d4cf6c667cc - avoid use of `std::filesystem::path` where possible: https://github.com/jamesob/bitcoin/commit/4ef785749ff1c481b5681739653c5b153637e44e -...

Post-merge ACK. This doc is very helpful, thanks @ryanofsky!

Approach ACK; seems like a reasonable feature reasonably implemented. Will do a more formal review soon.

Posthumous ACK https://github.com/bitcoin/bitcoin/commit/997b9a73e5166b4244f7c5b4fe144d524f3005f4 Was just in the middle of reviewing this and figuring out how to add some balance checks. May file a followup.

I think it would be worth moving most conceptual discussion to the [Delving Bitcoin thread](https://delvingbitcoin.org/t/covenant-tools-softfork/98) to avoid blasting the already-burdened Github notifications of contributors here.