James Koster
James Koster
An alternative approach here would be to keep the menu item visible, but make it disabled, or show a lock icon. I decided to try hiding it altogether inspired by...
@oandregal Good catch. Do you think it would make sense to simply disable the last visible field (when there's no title/media/description)? Is that possible?
I pushed some style changes, most notably inline and block padding are now applied to ensure density is respected. The trade-off (compared to defining an explicit height) is that the...
I'd welcome @poligilad-auto's thoughts on this detail; the no-tone badge is 2px larger than the others due to its border. Do you think this is problematic? If so how do...
Let's see what happens with https://github.com/WordPress/gutenberg/pull/74001, if that merges we can keep the border :)
I removed the border :D
I'm going to merge this as I think it's in a good spot now, but will circle back to address the styling comments by adopting `Text` once https://github.com/WordPress/gutenberg/pull/73931 is merged.
This is looking good, though I'm a little anxious about hiding the title on mobile since it removes access to the Command Palette. I've seen comments elsewhere about revealing the...
Ah, I guess it's because the Preview action is bundled in the device preview toggles on desktop. Obviously these aren't applicable on smaller screens, hence they get replaced with the...
Obviously the mobile experience is not perfect, but the enhancements here are a step in the right direction compared to trunk. I think this one just needs a code review.