James Koster

Colors seem to be scoped correctly for me 👍 Border width interactive doesn't seem to be scoped. Neither do any of the dimension tokens. --- ~Related to this work, do...

Oh, I just noticed that border colors are scoped to 'Effects' rather than 'Stroke'.

Typography tokens are also unscoped. I'm wondering if all the unscoped tokens are a 'me' problem 🙈

I asked AI and was able to fix the dimension tokens in https://github.com/WordPress/gutenberg/pull/73897/commits/696d5f299cd222ad9e053d2cca04fdbb6527f909. > The issue was that Figma's token import doesn't inherit group-level $extensions when individual tokens already define...

Seems we were using the wrong scope name for stroke. I fixed that (and removed effects as I don't think it's needed) in https://github.com/WordPress/gutenberg/pull/73897/commits/bf1e67f8065dbf4eaae859e19e5872ad63456ddb.

Tokens are now all importing with correct scoping for me.

> The individual tokens didn't define $extensions The dimensions tokens did, no? There's a `mode` extension for the different densities. > Figma's official documentation mentions STROKE_COLOR and EFFECT_COLOR, but does...

I was looking for this option just yesterday, so I'm very happy to see this PR! In terms of design everything looks good to me, and the option seems to...

+1 for the more semantic name. 'Minimal' seems good. This implementation will work well for the filter operator UI, this one: I'm curious to gather more thoughts on the page...

> Can variant inherit text styles, instead of come with its own That's an interesting idea. > The design is solid enough Which one? :) As it stands, this design...