James Koster
James Koster
I agree that we should avoid ad hoc customisations of core components. However this doesn't feel like the right solution to me. Both buttons have way too much prominence given...
Thinking about this one a little more I think it might make sense to revisit once we've designed an accessible DropZone/Upload component. Ideally that could be used here without any...
If moving the featured image is on the table, and we feel it is too prominent, then we should also consider grouping it with all the other field rows. This...
Replacing / removing a featured image is a relatively uncommon task. Placing the buttons 'on top' of the image avoids adding unnecessary clutter to the UI, indirectly making more common...
The revisions button invokes a drilldown, which feels strange given the access point (panel header toggle button). I wouldn't object to moving this to the panel footer, similar to the...
Just to clarify, what does the end result look like? I'm curious about the roles each channel plays: 1. Readme file in components package 2. developer.wordpress.org 3. Storybook My understanding...
I haven't been very close to this work so take my feedback with a grain of salt, but I don't know that I'd equate a different toolbar color to a...
I certainly agree it's worth trying _something_ to help indicate the active mode. I'm not 100% sold on using the toolbar to do that because it's not always visible, and...
We also need to fix the contrast on toggled buttons.
Spotted another issue. Select a template part in the page editor and hover the name; it disappears: