James Koster

Results 557 comments of James Koster

A right border could help separate the pattern panel from the canvas?

Here's what I'm seeing in case it helps: https://user-images.githubusercontent.com/846565/189886970-edbbd639-0feb-4c8c-aa38-765c9a6e9706.mp4

This looks like a good start to me. Since it's one part of some other "interface personalisation" ideas, maybe we should open a tracking issue that encapsulates everything? In terms...

> So are users just not supposed to format their content in this mode? That does not make much sense to me. I could see hiding the toolbar to have...

Very excited to see some work on this! :) I'm unable to explain why, but I am seeing small flashes of content behind the loader: https://user-images.githubusercontent.com/846565/179752673-1378299b-5f21-4d07-8457-1c11fb2d0e63.mp4 Let me know how...

> @jameskoster I think this is kind of nonsense :D Maybe :D > I'd love to see some sort of a raw preview or demo A very rough idea: ![load](https://user-images.githubusercontent.com/846565/182811510-0fa11223-4732-4274-8201-8678a50bd46b.gif)...

Here's this PR as things stand: ![loader](https://user-images.githubusercontent.com/846565/185075190-5df6be81-66a6-4cd7-8048-a6872ac9e063.gif) It's already in a decent spot imo, and potentially mergeable assuming subsequent refinements. If it's easy to try, we could use a slightly...

One issue to fix: The loading state should (for now) only be displayed when you first open the Site Editor. At the moment I noticed it pops up when you...

It's not a strong opinion, but it's a little strange to have access to things like the Inserter before the document is visible. It might be worth trying a version...

The only issue with the light grey is that the active item now looks very similar to the search box above the tabs 🤔 I agree the blue indicator from...