James Koster
James Koster
Just connecting a dot that @critterverse pointed out to me... the work here could go a long way towards closing https://github.com/WordPress/gutenberg/issues/41397 as well. If it's not suitable to include in...
> I think it makes sense to break this up into two or three PRs along those lines. Yeah that seems like a good idea. I suppose this PR can...
> We don't have an internationalized plural form of the area label, but I can look at adding this. No worries, let's do it in a follow up. I'll make...
I just noticed something else, unsure if it's only on this PR or an existing problem; if you drag 'Header' from the Inserter on to the canvas nothing happens.
@paaljoachim please see the three bullet points at the end of [this comment](https://github.com/WordPress/gutenberg/pull/42142#issuecomment-1180391165) for an overview of what we're considering. This PR originally concentrated on the second point, but kind...
> I've put together an alternative PR - https://github.com/WordPress/gutenberg/pull/42581. Good to try! Having both behaviours (open modal and insert block) execute concurrently feels a little bit clunky to me. I...
Nice! I think we're just missing a solution to the duplicate name issue, and the start blank affordance.
Oh good idea. We can probably just use the [Spinner](https://wordpress.github.io/gutenberg/?path=/story/components-spinner--custom-size) component.
Here's where we are: https://user-images.githubusercontent.com/846565/182835821-d128351f-4446-4c0e-8418-34c91e885005.mp4 The spinner appearing above the content feels a bit awkward, could we place a white scrim over them, or just hide them? Otherwise we're looking...
> There is an overlay, but maybe it's too subtle. I've pushed a commit to make it more obvious. Much better! :) I think this PR is ready for a...