James Koster
James Koster
There's may be a better way, but I pushed a commit which applies `aria-disabled` to busy buttons. Also fixed the active states.
@WordPress/gutenberg-components does someone have a moment to review this one? :)
> Do you get the same results if you provide color value as HEX? Yep, it's exactly the same.
I noticed a similar thing happens with the border radius control. If my theme sets a radius on the Image block, that is applied on the canvas and the frontend...
> I am not able to see where this vertical layout is used? Enable the "New admin views" experiment in Gutenberg then navigate to Appearance > Editor > Templates >...
I think this is much less of an issue since Grid was made the default layout for templates, but it would be good to auto-hide the description when switching from...
Yup. You could also manually expose the description in view options if you really need to see it in this layout.
> Suppose the description field is not hidden. > And now I switch to the "List" layout and the description field becomes auto-hidden. > Now when I switch to any...
I think there's potentially another element to this that I overlooked – when the color is inherited from a stylesheet (not necessarily theme.json). The control should account for those scenarios...
> On https://github.com/WordPress/gutenberg/pull/34178, I try to implement the case where we should the colors when they come from theme.json. Thanks for the effort there. I would love to see the...