James Koster
James Koster
I appreciate the effort to get this into 6.5, but I am hesitant to merge because one interaction feels a bit off; when you open a popover the first item...
I continue to wonder whether the management of multiple synced Navigation menus is over-emphasised in the site editor. Typically sites have one or two menus, and most of the time...
> That said, I'm curious to understand more about what you see as the "additional touchpoints" I'm basically referring to all the complexity that gets added by having to entertain...
Seems like a step in the right direction. Do you think we need the 'Skip' link for columns? There's a quirk in the hover interaction – you can cursor over...
Not for this PR, and I know we discussed it before, but I wonder if the thumbnail 'icons' could be inspiration for the de-selected state for empty groups and columns,...
Is the block name / icon supposed to be missing for Group? That's a bit unexpected. I like the full-width buttons in smaller spaces.
I see. I think I'd expect consistency either way. I suppose that's what @t-hamano is getting at... there are a few parts here: * Refining the Placeholder. * Refining BlockVariationPicker...
This feels pretty close, the 'regular' versions are looking good. Some of the alignment details in the reduced versions looks a little strange to me. The main offender is the...
Adding Bug label since the current code is effectively broken. If we can't restore this functionality for 6.5 then we should at least remove the broken code.
I have a potential fix, will open a PR.