James Koster
James Koster
Nice! This is working well for me. Would it be possible to also apply the styles to the placeholder you find in the template editor when a featured image isn't...
> I'd like to double-check how desirable applying borders to the placeholder actually is I think it's pretty important. Not so much in the post editor, but in the template...
@aaronrobertshaw could we remove the placeholder border together if one is added via the border control? 🤔
> Am I correct in assuming it is that dotted border you are asking if we can remove if a border is set? Yes. > We could if the border...
> So the question is: is that text-color dark outline good enough? Do you mean on the 'No color, but width and radius defined' config? That's a tricky one. It...
I think it's fine. In fact, I think I prefer it 😆
> I think this is acceptable. I agree. Still, it might be good to (separate to this PR) explore adding a background to the placeholder so that it is still...
Yeah I think it's fairly important for there to be a visual indication that pressing Enter will select the item. The current behaviour seems fairly intuitive to me: https://user-images.githubusercontent.com/846565/180462914-0a5dc65b-43f3-4164-82a3-d7155375b05c.mp4 Saving...
This looks much better to the eye – If the first result has focus then pressing Enter to select it seems fine to me. I do wonder about the a11y...
@glendaviesnz > If a default font size for a block is specified in global styles, the selected size is reflected in how big the font shows in the editor and...