Jamal James
Jamal James
Hey @Jem256, for each node, there is a folder on the host machine that contains the node's data. It's located at `~/.polar/networks//volumes///`. It looks like Polar isn't renaming this dir...
The [DockerService.ensureDirs](https://github.com/jamaljsr/polar/blob/master/src/lib/docker/dockerService.ts) is currently the method that initially creates this dir when it starts the containers. This seems like the most appropriate place to rename the dir when the node...
Hey @Jem256 please let me know when you feel this is ready for review and I'll take a look at it.
Yes, you can see coverage locally by running `yarn test:ci`. The output will show you which files have uncovered lines. Afterwards, you can also open the `coverage/lcov-report/index.html` file in a...
@Jem256 Thanks so much for getting this new feature 99% done. I'm planning a new release in the coming days and wanted to make sure this gets in it. So...
Good idea. Which OS are you running on? I suppose we should support this on all of them, but just curious.
ok, sounds good. thanks! 👍
Thanks for the feedback. I've received a similar request some time ago. I think the right approach would be to split all of the docker & compose logic out to...
Hey @Muniru0, I would not suggest starting development on this until we have a deep dive discussion on exactly how to implement it. We have to draw a line between...
@kelvinator07 I have pushed a commit to your branch that adds the additional unit tests needed to get the code coverage back to 100%. There were a couple of places...