Channel feature

[kelvinator07]

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (06a7210) to head (9243629). Report is 33 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##            master      #837    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          140       140            
  Lines         4428      4581   +153     
  Branches       862       852    -10     
==========================================
+ Hits          4428      4581   +153     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[kelvinator07]

@jamaljsr Thanks for the feedback. Would update and revert.

[kelvinator07]

@jamaljsr This PR has been updated based on your last comments and is ready to be reviewed.

[kelvinator07]

Thanks for the updates. This is getting very close to done.

I left a bit more feedback on your latest changes. It's mostly small stuff to tidy up the code.

The only other things to address are:

• rebase this branch on master
• fix unit tests and fill the remaining code coverage

Once these are done, I think this will be pretty much ready to merge.

Thanks for the feedback. Would wrap this up by the end of this week.

[kelvinator07]

Thanks for the updates. This is getting very close to done.

I left a bit more feedback on your latest changes. It's mostly small stuff to tidy up the code.

The only other things to address are:

• rebase this branch on master
• fix unit tests and fill the remaining code coverage

Once these are done, I think this will be pretty much ready to merge.

@jamaljsr PR has been updated based on your last comments and is ready to be reviewed. Thanks

[jamaljsr]

@kelvinator07 I have pushed a commit to your branch that adds the additional unit tests needed to get the code coverage back to 100%. There were a couple of places where code paths in the app were completely unreachable. I had to modify the implementation to eliminate those branches. This is one of the benefits of maintaining high coverage, it forces you to eliminate code that can never be executed.

I also did another round of testing for each implementation. The real time events are working great.

I am going to rebase this branch on master and once the CI completes, I will merge this PR. Thank you so much for completing this new feature. I'm looking forward to your next contribution 🎉

[jamaljsr]

Oh, I also forgot to mention that in #879 I upgraded Polar to use the latest Core Lightning implementation and switched to using the embedded REST API which now supports WebSocket streaming 🙌. So the I am going to remove the polling and implement receiving events via sockets in that PR.

[kelvinator07]

Oh, I also forgot to mention that in #879 I upgraded Polar to use the latest Core Lightning implementation and switched to using the embedded REST API which now supports WebSocket streaming 🙌. So the I am going to remove the polling and implement receiving events via sockets in that PR.

Awesome! I'll check out the PR.