Jamal James

Results 219 comments of Jamal James

I think I understand what you are trying to accomplish. You'd like some extensibility points added to Polar which would allow others to create widget-like plugins that add additional functionality,...

This is an interesting idea. It's not something I can prioritize working on at the moment, but I would be fine reviewing a PR if someone else wants to work...

That's a pretty cool idea. No objections from me if you want to implement this.

Make sure you're using the latest `master` branch. These issues should have been resolved by #827. I just tested with a fresh clone of the repo using node v20.9.0 and...

Yes, the `LightningService` will only return the channels that were opened by the supplied node. This was the simpler approach to avoid creating duplicate links in the chart. There is...

Apologies for the delay in reviewing this. I've been traveling. I'll test this out and provide feedback by the end of the week. Thanks for tackling this issue.

Hey @amovfx thanks for the updates. I'll take a look at this in the next few days.

I have tested the functionality. Great job querying for the list of existing networks. That's a great touch 👌 I do have some suggestions for improvement: 1. When creating a...

The code currently on Github is missing the `lightning.renameNode()` function and is throwing an error, so I don't see the issue you're having. ![image](https://github.com/jamaljsr/polar/assets/1356600/8c2f538c-a32c-4b89-be48-b77bd176530d)

> I have a question though, about Number 4, should we remove the button and simply have the modal accessible through the right click menu or should we have both?...