Jakob Botsch Nielsen
Jakob Botsch Nielsen
@kunalspathak this code in `emitLoopAlign` looks suspicious to me: https://github.com/dotnet/runtime/blob/2db51aa5539ad9e444d33574459374680a4ba098/src/coreclr/jit/emit.cpp#L5192-L5217 `emitNewInstrAlign` can create new IGs for other reasons than `emitForceNewIG`, for example if we do not have enough space in...
BTW, do we want to make `COMPlus_JitStdOutFile` available in release too? It will potentially allow us to use release jits with SPMI asmdiffs/jit-diff.
> Can we do that in follow-ups? Sounds fine to me (I also looked into it a bit and it might not be that trivial). We should probably run most...
I have started a non-PR run of `runtime` [here](https://dev.azure.com/dnceng/public/_build/results?buildId=1929144&view=results), which will get us some more coverage for release JIT with the libraries tests. The change is somewhat low risk for...
I pushed a commit that adds `emitFirstInstrDesc` and `emitAdvanceInstrDesc` and uses these in place of the manual `castto`/buffer accesses, which consolidates most uses of `m_debugInfoSize`.
> Does the JIT dll import table change? (I.e., are there any new dependencies in the Release build?) We get two new IAT entries on Windows: `__stdio_common_vsprintf_s` and `strnlen`.
Much simpler example: ```coq From Equations Require Import Equations. Equations eta_expand : nat := eta_expand with 0 := | n with 5 := | n := n. Compute eta_expand. ```
cc @dotnet/jit-contrib, simple change with [no diffs](https://dev.azure.com/dnceng-public/public/_build/results?buildId=18123&view=ms.vss-build-web.run-extensions-tab) and some small TP improvements.
@AndyAyersMS Can you take another look?
Diffs look spurious (#53773). I think the #53773 problem is more pronounced now that we have frozen objects too, we probably need a few JIT-EE interface changes to make sure...