runtime icon indicating copy to clipboard operation
runtime copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

JIT: Update gtHasLocalsWithAddrOp to use GenTreeVisitor

Open jakobbotsch opened this issue 2 years ago • 5 comments

Also change it to check for any local, not just GT_LCL_VAR.

jakobbotsch avatar Sep 15 '22 10:09 jakobbotsch

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch See info in area-owners.md if you want to be subscribed.

Issue Details

Also change it to check for any local, not just GT_LCL_VAR.

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

ghost avatar Sep 15 '22 10:09 ghost

cc @dotnet/jit-contrib, simple change with no diffs and some small TP improvements.

jakobbotsch avatar Sep 16 '22 11:09 jakobbotsch

@AndyAyersMS Can you take another look?

jakobbotsch avatar Sep 19 '22 09:09 jakobbotsch

Diffs look spurious (#53773). I think the #53773 problem is more pronounced now that we have frozen objects too, we probably need a few JIT-EE interface changes to make sure that we can use the captured field addresses/object addresses during SPMI (JIT probably needs to ask the EE about values instead of dereferencing them directly, should probably help R2R/NAOT too). cc @EgorBo

jakobbotsch avatar Sep 19 '22 10:09 jakobbotsch

Ping @AndyAyersMS

jakobbotsch avatar Sep 20 '22 16:09 jakobbotsch