Jake Coffman

Dependabot should not add build info to the manifest with NuGet

2

This is a follow-on to #4845. It is an ecosystem best practice to drop the build identifier from the version when adding dependencies to a .NET project. [Here's an example...

no audio?

13

Great project! I'm not getting any audio with my stream. Is that to be expected?

In some cases we convert to `[]byte` when leaving `[]rune` would be less wasteful and more straight forward. This will require a major version bump.

streams are UTF-8

1

Thanks to @kriive for pointing this out in #8. Currently the streaming is counted by bytes, but it should be counted by UTF-8 rune. In addition to updating Parse, we...

allow interactive debugging in the CLI

1

When running in the CLI with `script/dependabot`, this allows us to add `debugger` in the code and then invoke `bin/run fetch_files --debug` to start a debugging session once that line...

make DependencySnapshot aware of multiple directories

2

This PR refactors DependencySnapshot to be aware of multiple directories. ## Why Previously DependencySnapshot would take all of the dependency files and attempt to parse them to discover the dependencies....

use context.Context for timing out operations

4

Currently there's no way to set a timeout for an operation using this library. Generally this is done in Go using the context package: https://blog.golang.org/context In a fork I've begun...

These attributes are in the xml of a vapp-template query but aren't mapped in QueryResultVappTemplateType (or the admin one) so the data is lost. ``` NumberOfVMs int `xml:"numberOfVMs,attr,omitempty"` NumberOfCPUs int...

```go func TestRadixTree_trailingSlashBug(t *testing.T) { tree := radix.New(0) tree.Add("/test/:ok", 1) tree.SetBoundaries(':', '/') tree.Get("/test") // ok tree.Get("/test/") // panic } ```

Here's a test that illustrates the issue. Since `:page` and `:slug` are different they seem to cause an issue and the `node.Value` becomes `nil`. One could argue "well then don't...