guac icon indicating copy to clipboard operation
guac copied to clipboard

Published 20 hours ago • verified publisher icon wwt

streams are UTF-8

Open jakecoffman opened this issue 3 years ago • 1 comments

Thanks to @kriive for pointing this out in #8.

Currently the streaming is counted by bytes, but it should be counted by UTF-8 rune.

In addition to updating Parse, we need to update ReadSome. Are there any other places?

jakecoffman avatar Feb 01 '22 16:02 jakecoffman

Yes, I guess Guacamole mostly uses ASCII (which maps to UTF-8 single byte) so it's understandable it didn't show up! Maybe if a user uses emojis in hostnames or password (oh dear...) it could cause some issues.

kriive avatar Feb 01 '22 17:02 kriive