Jake Bailey
Jake Bailey
Is there anything left to do here? It's got conflicts, but it's approved by two people.
Er, 5.2 has already branched off, and the tree is open for 5.3 development; we're in the early stage of the cycle, unless you're worried about our ability to cherry...
Just to show before I fix them: https://github.com/microsoft/TypeScript/actions/runs/4895891571/jobs/8742024956?pr=54141
Where is this location coming from? All source files should be bound and have parents, so is this location the SourceFile itself?
Are the details in https://github.com/microsoft/TypeScript/blob/main/tests/cases/fourslash/completionsObjectLiteralMethod2.ts what you're trying to get at?
Feel free to send a PR: https://github.com/microsoft/TypeScript-error-deltas See userTests. Of course, any PR would include a test case for this.
Seems like the library is still working through a few issues.
The upstream bug for this appears to have been closed with a fix, but, this code still fails to compile ☹️
Alright, it's now fixed, so this PR should be ready to go.
> I'm surprised that there are significant deltas with `main`. Is it perhaps because this branch is pretty outdated (or is the perf run rebasing with `main` before running everything)?...