Jake Bailey comments

Results 1420 comments of


                                            Jake Bailey

Use union types for all common classes of AST nodes

> Incremental rebuilds are a rebuild-accelerating thing now, so I think this is more palatable nowadays (because a fresh build does still take about 2.7x longer than main today does)....

Use union types for all common classes of AST nodes

A quick glance at a profile for this shows a bunch of suspicious new calls for `getResolvedSignature` which spend a lot of time in inferTypeArguments (a full second each time...

Use union types for all common classes of AST nodes

I did a quick debug print to show which of these `getResolvedSignatures` took more than 500ms, and they are these expressions: ``` new (TokenConstructor || (TokenConstructor = objectAllocator.getTokenConstructor()))(kind, /*pos*/ -1,...

Fix `isGenericReducibleType` to allow HKT technique to function again

@typescript-bot pack this

Fix `isGenericReducibleType` to allow HKT technique to function again

@typescript-bot pack this

Parameters created from tuple are treated as mutable instead of immutable, unless written as "...args"

Followup is here: #53398

Parameters created from tuple are treated as mutable instead of immutable, unless written as "...args"

Fix has been reverted.

Parameters created from tuple are treated as mutable instead of immutable, unless written as "...args"

No, I just haven't come up with a fix for it, and have been working on other issues.

Bloomberg feedback for 5.1 beta

> We need to support running the compiler itself (not the output of the compiler) on runtimes that don’t yet have support for the `??` operator. We plan to drop...

Include source node inferences in string literal completions

@typescript-bot user test tsserver @typescript-bot test tsserver top100 @typescript-bot pack this