TypeScript Support control flow analysis for tagged template calls

Fixes #51426. Note that it's not on the Backlog milestone, but the issue hasn't had any activity for a month so I thought I'd try sending a PR for review anyway.

Apr 22 '23 12:04 71

The TypeScript team hasn't accepted the linked issue #51426. If you can get it accepted, this PR will have a better chance of being reviewed.

Apr 22 '23 12:04 typescript-bot

@typescript-bot perf test this

May 02 '23 22:05 sandersn

Heya @sandersn, I've started to run the perf test suite on this PR at de96190401979ebebbc7089fe5ac87673f1a6191. You can monitor the build here.

Update: The results are in!

May 02 '23 22:05 typescript-bot

@sandersn The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53962

_Metric	_main	₅₃₉₆₂	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{365,860k (± 0.01%)}	_{365,875k (± 0.01%)}	_~	_365,837k	_365,932k	_{p=0.336 n=6}
_{Parse Time}	_{3.39s (± 0.51%)}	_{3.43s (± 0.81%)}	_{+0.04s (+ 1.18%)}	_3.40s	_3.47s	_{p=0.019 n=6}
_{Bind Time}	_{1.11s (± 0.73%)}	_{1.12s (± 0.92%)}	_~	_1.10s	_1.13s	_{p=0.546 n=6}
_{Check Time}	_{8.76s (± 0.31%)}	_{8.73s (± 0.24%)}	_~	_8.71s	_8.76s	_{p=0.087 n=6}
_{Emit Time}	_{7.43s (± 0.22%)}	_{7.43s (± 0.87%)}	_~	_7.37s	_7.55s	_{p=0.517 n=6}
_{Total Time}	_{20.69s (± 0.17%)}	_{20.70s (± 0.43%)}	_~	_20.60s	_20.86s	_{p=0.936 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{192,842k (± 1.50%)}	_{190,977k (± 0.02%)}	_~	_190,921k	_191,044k	_{p=0.471 n=6}
_{Parse Time}	_{1.50s (± 0.56%)}	_{1.50s (± 1.36%)}	_~	_1.46s	_1.52s	_{p=0.326 n=6}
_{Bind Time}	_{0.77s (± 0.97%)}	_{0.78s (± 0.66%)}	_~	_0.77s	_0.78s	_{p=0.247 n=6}
_{Check Time}	_{9.60s (± 0.53%)}	_{9.69s (± 0.60%)}	_{+0.08s (+ 0.87%)}	_9.64s	_9.77s	_{p=0.030 n=6}
_{Emit Time}	_{2.76s (± 1.24%)}	_{2.75s (± 1.05%)}	_~	_2.71s	_2.79s	_{p=0.515 n=6}
_{Total Time}	_{14.63s (± 0.43%)}	_{14.71s (± 0.31%)}	_~	_14.65s	_14.78s	_{p=0.064 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{346,570k (± 0.01%)}	_{346,561k (± 0.02%)}	_~	_346,461k	_346,609k	_{p=1.000 n=6}
_{Parse Time}	_{2.59s (± 0.82%)}	_{2.59s (± 0.82%)}	_~	_2.56s	_2.62s	_{p=0.935 n=6}
_{Bind Time}	_{1.01s (± 0.81%)}	_{1.00s (± 0.75%)}	_~	_0.99s	_1.01s	_{p=0.383 n=6}
_{Check Time}	_{7.19s (± 0.59%)}	_{7.17s (± 0.42%)}	_~	_7.13s	_7.21s	_{p=0.627 n=6}
_{Emit Time}	_{4.28s (± 1.23%)}	_{4.27s (± 0.96%)}	_~	_4.22s	_4.31s	_{p=1.000 n=6}
_{Total Time}	_{15.06s (± 0.64%)}	_{15.03s (± 0.52%)}	_~	_14.93s	_15.13s	_{p=0.810 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,746k (± 0.01%)}	_{300,766k (± 0.01%)}	_~	_300,742k	_300,796k	_{p=0.149 n=6}
_{Parse Time}	_{2.06s (± 1.08%)}	_{2.07s (± 1.03%)}	_~	_2.05s	_2.10s	_{p=0.934 n=6}
_{Bind Time}	_{1.15s (± 1.19%)}	_{1.13s (± 0.46%)}	_~	_1.13s	_1.14s	_{p=0.051 n=6}
_{Check Time}	_{6.62s (± 0.48%)}	_{6.65s (± 0.50%)}	_~	_6.60s	_6.69s	_{p=0.228 n=6}
_{Emit Time}	_{3.88s (± 0.54%)}	_{3.89s (± 0.38%)}	_~	_3.87s	_3.91s	_{p=0.417 n=6}
_{Total Time}	_{13.70s (± 0.39%)}	_{13.74s (± 0.38%)}	_~	_13.68s	_13.82s	_{p=0.376 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{482,310k (± 0.01%)}	_{482,303k (± 0.01%)}	_~	_482,261k	_482,359k	_{p=0.689 n=6}
_{Parse Time}	_{3.09s (± 0.58%)}	_{3.10s (± 0.67%)}	_~	_3.08s	_3.14s	_{p=0.289 n=6}
_{Bind Time}	_{0.92s (± 0.89%)}	_{0.91s (± 0.83%)}	_~	_0.90s	_0.92s	_{p=0.082 n=6}
_{Check Time}	_{16.82s (± 0.47%)}	_{16.81s (± 0.30%)}	_~	_16.76s	_16.90s	_{p=0.628 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.82s (± 0.41%)}	_{20.83s (± 0.35%)}	_~	_20.75s	_20.94s	_{p=0.808 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{562,859k (± 0.02%)}	_{562,781k (± 0.01%)}	_~	_562,722k	_562,836k	_{p=0.377 n=6}
_{Parse Time}	_{3.82s (± 0.65%)}	_{3.85s (± 0.69%)}	_~	_3.80s	_3.87s	_{p=0.077 n=6}
_{Bind Time}	_{1.63s (± 0.64%)}	_{1.64s (± 0.64%)}	_{+0.02s (+ 1.23%)}	_1.63s	_1.66s	_{p=0.029 n=6}
_{Check Time}	_{2.81s (± 0.39%)}	_{2.83s (± 0.57%)}	_{+0.02s (+ 0.77%)}	_2.81s	_2.85s	_{p=0.032 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.33s (± 0.33%)}	_{8.40s (± 0.42%)}	_{+0.07s (+ 0.84%)}	_8.35s	_8.44s	_{p=0.013 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,241k (± 0.00%)}	_{365,265k (± 0.01%)}	_~	_365,200k	_365,320k	_{p=0.229 n=6}
_{Parse Time}	_{3.58s (± 1.08%)}	_{3.58s (± 0.80%)}	_~	_3.54s	_3.62s	_{p=1.000 n=6}
_{Bind Time}	_{1.18s (± 0.87%)}	_{1.18s (± 0.64%)}	_~	_1.17s	_1.19s	_{p=0.931 n=6}
_{Check Time}	_{9.60s (± 0.81%)}	_{9.61s (± 0.55%)}	_~	_9.53s	_9.67s	_{p=0.687 n=6}
_{Emit Time}	_{7.93s (± 0.52%)}	_{7.93s (± 0.85%)}	_~	_7.85s	_8.03s	_{p=0.748 n=6}
_{Total Time}	_{22.29s (± 0.62%)}	_{22.30s (± 0.57%)}	_~	_22.16s	_22.47s	_{p=0.873 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,761k (± 0.03%)}	_{192,737k (± 0.02%)}	_~	_192,683k	_192,826k	_{p=0.521 n=6}
_{Parse Time}	_{1.60s (± 0.47%)}	_{1.61s (± 0.82%)}	_~	_1.59s	_1.62s	_{p=0.094 n=6}
_{Bind Time}	_{0.83s (± 0.00%)}	_{0.83s (± 0.00%)}	_~	_0.83s	_0.83s	_{p=1.000 n=6}
_{Check Time}	_{10.31s (± 0.35%)}	_{10.41s (± 0.88%)}	_~	_10.29s	_10.54s	_{p=0.077 n=6}
_{Emit Time}	_{3.02s (± 0.77%)}	_{3.02s (± 0.47%)}	_~	_3.00s	_3.04s	_{p=0.870 n=6}
_{Total Time}	_{15.75s (± 0.40%)}	_{15.87s (± 0.65%)}	_~	_15.72s	_16.02s	_{p=0.078 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,850k (± 0.00%)}	_{345,855k (± 0.00%)}	_~	_345,836k	_345,868k	_{p=0.575 n=6}
_{Parse Time}	_{2.71s (± 0.40%)}	_{2.75s (± 0.87%)}	_{+0.04s (+ 1.41%)}	_2.72s	_2.79s	_{p=0.009 n=6}
_{Bind Time}	_{1.09s (± 0.47%)}	_{1.08s (± 0.59%)}	_~	_1.07s	_1.09s	_{p=0.091 n=6}
_{Check Time}	_{7.88s (± 0.31%)}	_{7.88s (± 0.74%)}	_~	_7.81s	_7.98s	_{p=0.809 n=6}
_{Emit Time}	_{4.48s (± 1.12%)}	_{4.51s (± 0.65%)}	_~	_4.47s	_4.54s	_{p=0.377 n=6}
_{Total Time}	_{16.16s (± 0.37%)}	_{16.21s (± 0.52%)}	_~	_16.10s	_16.35s	_{p=0.258 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,094k (± 0.00%)}	_{300,122k (± 0.01%)}	_~	_300,087k	_300,151k	_{p=0.078 n=6}
_{Parse Time}	_{2.15s (± 0.35%)}	_{2.17s (± 0.54%)}	_{+0.02s (+ 0.93%)}	_2.16s	_2.19s	_{p=0.011 n=6}
_{Bind Time}	_{1.24s (± 0.88%)}	_{1.24s (± 0.83%)}	_~	_1.22s	_1.25s	_{p=0.863 n=6}
_{Check Time}	_{7.26s (± 0.30%)}	_{7.30s (± 0.62%)}	_~	_7.25s	_7.34s	_{p=0.217 n=6}
_{Emit Time}	_{4.36s (± 0.73%)}	_{4.38s (± 0.88%)}	_~	_4.32s	_4.42s	_{p=0.469 n=6}
_{Total Time}	_{15.02s (± 0.24%)}	_{15.09s (± 0.32%)}	_{+0.08s (+ 0.50%)}	_15.04s	_15.15s	_{p=0.012 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,626k (± 0.01%)}	_{481,595k (± 0.01%)}	_~	_481,538k	_481,641k	_{p=0.378 n=6}
_{Parse Time}	_{3.23s (± 0.23%)}	_{3.26s (± 0.46%)}	_{+0.03s (+ 0.98%)}	_3.25s	_3.28s	_{p=0.004 n=6}
_{Bind Time}	_{0.94s (± 0.80%)}	_{0.94s (± 0.43%)}	_~	_0.93s	_0.94s	_{p=1.000 n=6}
_{Check Time}	_{17.88s (± 0.51%)}	_{17.89s (± 0.38%)}	_~	_17.78s	_17.96s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.05s (± 0.44%)}	_{22.08s (± 0.39%)}	_~	_21.96s	_22.18s	_{p=0.630 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{560,407k (± 0.01%)}	_{560,308k (± 0.01%)}	_{-99k (- 0.02%)}	_560,255k	_560,400k	_{p=0.045 n=6}
_{Parse Time}	_{3.99s (± 0.56%)}	_{4.01s (± 0.30%)}	_~	_4.00s	_4.03s	_{p=0.107 n=6}
_{Bind Time}	_{1.76s (± 0.47%)}	_{1.76s (± 0.47%)}	_~	_1.75s	_1.77s	_{p=0.796 n=6}
_{Check Time}	_{3.06s (± 0.17%)}	_{3.06s (± 0.57%)}	_~	_3.03s	_3.08s	_{p=1.000 n=6}
_{Emit Time}	_{0.09s (± 4.62%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{8.90s (± 0.33%)}	_{8.93s (± 0.37%)}	_~	_8.89s	_8.98s	_{p=0.195 n=6}
_{Angular - node (v14.21.3, x64)}
_{Memory used}	_{359,297k (± 0.01%)}	_{359,278k (± 0.01%)}	_~	_359,250k	_359,327k	_{p=0.128 n=6}
_{Parse Time}	_{3.67s (± 0.47%)}	_{3.69s (± 0.28%)}	_{+0.02s (+ 0.59%)}	_3.68s	_3.71s	_{p=0.021 n=6}
_{Bind Time}	_{1.21s (± 0.45%)}	_{1.22s (± 0.69%)}	_~	_1.21s	_1.23s	_{p=0.855 n=6}
_{Check Time}	_{9.99s (± 0.53%)}	_{10.01s (± 0.54%)}	_~	_9.94s	_10.09s	_{p=0.574 n=6}
_{Emit Time}	_{8.28s (± 0.70%)}	_{8.29s (± 0.32%)}	_~	_8.26s	_8.32s	_{p=0.332 n=6}
_{Total Time}	_{23.15s (± 0.33%)}	_{23.21s (± 0.28%)}	_~	_23.15s	_23.32s	_{p=0.261 n=6}
_{Compiler-Unions - node (v14.21.3, x64)}
_{Memory used}	_{188,110k (± 0.01%)}	_{188,119k (± 0.01%)}	_~	_188,094k	_188,163k	_{p=0.630 n=6}
_{Parse Time}	_{1.60s (± 0.85%)}	_{1.62s (± 1.02%)}	_~	_1.59s	_1.63s	_{p=0.214 n=6}
_{Bind Time}	_{0.85s (± 0.48%)}	_{0.85s (± 0.48%)}	_~	_0.85s	_0.86s	_{p=0.218 n=6}
_{Check Time}	_{10.46s (± 0.52%)}	_{10.50s (± 0.81%)}	_~	_10.37s	_10.63s	_{p=0.376 n=6}
_{Emit Time}	_{3.18s (± 0.97%)}	_{3.18s (± 0.76%)}	_~	_3.15s	_3.22s	_{p=0.746 n=6}
_{Total Time}	_{16.09s (± 0.39%)}	_{16.14s (± 0.64%)}	_~	_15.96s	_16.28s	_{p=0.261 n=6}
_{Monaco - node (v14.21.3, x64)}
_{Memory used}	_{340,968k (± 0.01%)}	_{340,965k (± 0.00%)}	_~	_340,952k	_340,983k	_{p=0.297 n=6}
_{Parse Time}	_{2.79s (± 0.54%)}	_{2.81s (± 0.43%)}	_{+0.02s (+ 0.72%)}	_2.80s	_2.83s	_{p=0.042 n=6}
_{Bind Time}	_{1.11s (± 1.05%)}	_{1.11s (± 1.09%)}	_~	_1.10s	_1.13s	_{p=0.502 n=6}
_{Check Time}	_{8.16s (± 0.47%)}	_{8.19s (± 0.15%)}	_~	_8.17s	_8.20s	_{p=0.368 n=6}
_{Emit Time}	_{4.73s (± 0.75%)}	_{4.74s (± 0.39%)}	_~	_4.71s	_4.76s	_{p=0.935 n=6}
_{Total Time}	_{16.80s (± 0.26%)}	_{16.85s (± 0.15%)}	_~	_16.80s	_16.87s	_{p=0.060 n=6}
_{TFS - node (v14.21.3, x64)}
_{Memory used}	_{295,290k (± 0.00%)}	_{295,301k (± 0.00%)}	_~	_295,288k	_295,315k	_{p=0.065 n=6}
_{Parse Time}	_{2.39s (± 0.82%)}	_{2.40s (± 0.57%)}	_~	_2.39s	_2.43s	_{p=0.183 n=6}
_{Bind Time}	_{1.07s (± 0.78%)}	_{1.07s (± 0.70%)}	_~	_1.06s	_1.08s	_{p=0.172 n=6}
_{Check Time}	_{7.59s (± 0.49%)}	_{7.65s (± 0.39%)}	_{+0.06s (+ 0.79%)}	_7.61s	_7.70s	_{p=0.019 n=6}
_{Emit Time}	_{4.35s (± 0.84%)}	_{4.38s (± 0.64%)}	_~	_4.35s	_4.42s	_{p=0.145 n=6}
_{Total Time}	_{15.39s (± 0.33%)}	_{15.51s (± 0.33%)}	_{+0.12s (+ 0.77%)}	_15.43s	_15.58s	_{p=0.013 n=6}
_{material-ui - node (v14.21.3, x64)}
_{Memory used}	_{477,188k (± 0.01%)}	_{477,186k (± 0.01%)}	_~	_477,154k	_477,224k	_{p=0.810 n=6}
_{Parse Time}	_{3.32s (± 0.45%)}	_{3.33s (± 0.84%)}	_~	_3.29s	_3.36s	_{p=0.325 n=6}
_{Bind Time}	_{1.00s (± 0.41%)}	_{1.00s (± 0.75%)}	_~	_0.99s	_1.01s	_{p=0.389 n=6}
_{Check Time}	_{18.76s (± 0.70%)}	_{18.85s (± 0.74%)}	_~	_18.70s	_19.01s	_{p=0.468 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.08s (± 0.62%)}	_{23.19s (± 0.62%)}	_~	_23.04s	_23.35s	_{p=0.092 n=6}
_{xstate - node (v14.21.3, x64)}
_{Memory used}	_{549,321k (± 0.00%)}	_{549,342k (± 0.00%)}	_~	_549,323k	_549,362k	_{p=0.128 n=6}
_{Parse Time}	_{4.19s (± 0.37%)}	_{4.22s (± 0.59%)}	_{+0.03s (+ 0.76%)}	_4.19s	_4.26s	_{p=0.022 n=6}
_{Bind Time}	_{1.66s (± 2.25%)}	_{1.67s (± 2.56%)}	_~	_1.58s	_1.69s	_{p=0.084 n=6}
_{Check Time}	_{3.18s (± 0.62%)}	_{3.18s (± 0.66%)}	_~	_3.15s	_3.20s	_{p=0.687 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.11s (± 0.59%)}	_{9.16s (± 0.39%)}	_~	_9.11s	_9.20s	_{p=0.092 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.21.3, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.21.3, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.21.3, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.21.3, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.21.3, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₉₆₂	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..53962

_Metric	_main	₅₃₉₆₂	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,532ms (± 0.76%)}	_{2,542ms (± 0.75%)}	_~	_2,516ms	_2,564ms	_{p=0.470 n=6}
_{Req 2 - geterr}	_{5,742ms (± 0.62%)}	_{5,750ms (± 0.24%)}	_~	_5,729ms	_5,767ms	_{p=0.810 n=6}
_{Req 3 - references}	_{344ms (± 0.93%)}	_{344ms (± 0.70%)}	_~	_342ms	_348ms	_{p=0.808 n=6}
_{Req 4 - navto}	_{282ms (± 0.59%)}	_{285ms (± 1.41%)}	_~	_279ms	_291ms	_{p=0.170 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 1.24%)}	_{85ms (± 1.21%)}	_~	_84ms	_87ms	_{p=0.241 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,647ms (± 0.88%)}	_{2,661ms (± 0.37%)}	_~	_2,646ms	_2,671ms	_{p=0.093 n=6}
_{Req 2 - geterr}	_{4,316ms (± 1.73%)}	_{4,369ms (± 0.29%)}	_{+53ms (+ 1.22%)}	_4,353ms	_4,389ms	_{p=0.020 n=6}
_{Req 3 - references}	_{347ms (± 0.51%)}	_{351ms (± 1.04%)}	_~	_347ms	_356ms	_{p=0.102 n=6}
_{Req 4 - navto}	_{291ms (± 0.85%)}	_{289ms (± 0.55%)}	_~	_287ms	_291ms	_{p=0.145 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{64ms (± 5.41%)}	_{64ms (± 4.17%)}	_~	_62ms	_69ms	_{p=1.000 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,078ms (± 0.71%)}	_{3,083ms (± 1.05%)}	_~	_3,040ms	_3,129ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{1,597ms (± 1.11%)}	_{1,609ms (± 1.33%)}	_~	_1,582ms	_1,633ms	_{p=0.334 n=6}
_{Req 3 - references}	_{107ms (± 1.72%)}	_{109ms (± 3.23%)}	_~	_106ms	_115ms	_{p=0.406 n=6}
_{Req 4 - navto}	_{363ms (± 0.47%)}	_{364ms (± 0.51%)}	_~	_362ms	_367ms	_{p=0.565 n=6}
_{Req 5 - completionInfo count}	_{2,862 (± 0.00%)}	_{2,862 (± 0.00%)}	_~	_2,862	_2,862	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{373ms (± 1.07%)}	_{377ms (± 0.90%)}	_~	_371ms	_380ms	_{p=0.195 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,673ms (± 0.66%)}	_{2,675ms (± 0.58%)}	_~	_2,660ms	_2,703ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{6,194ms (± 0.59%)}	_{6,206ms (± 0.91%)}	_~	_6,140ms	_6,299ms	_{p=0.810 n=6}
_{Req 3 - references}	_{353ms (± 0.86%)}	_{356ms (± 0.63%)}	_~	_353ms	_359ms	_{p=0.145 n=6}
_{Req 4 - navto}	_{284ms (± 0.59%)}	_{287ms (± 1.18%)}	_~	_283ms	_292ms	_{p=0.163 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{86ms (± 6.28%)}	_{88ms (± 7.39%)}	_~	_79ms	_94ms	_{p=0.743 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,820ms (± 0.53%)}	_{2,829ms (± 0.70%)}	_~	_2,804ms	_2,855ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{4,726ms (± 0.50%)}	_{4,716ms (± 0.41%)}	_~	_4,686ms	_4,742ms	_{p=0.575 n=6}
_{Req 3 - references}	_{363ms (± 0.59%)}	_{362ms (± 0.33%)}	_~	_361ms	_364ms	_{p=0.415 n=6}
_{Req 4 - navto}	_{286ms (± 0.87%)}	_{285ms (± 0.88%)}	_~	_282ms	_288ms	_{p=0.807 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{68ms (± 0.60%)}	_{67ms (± 1.13%)}	_{-1ms (- 1.47%)}	_66ms	_68ms	_{p=0.029 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,211ms (± 0.47%)}	_{3,219ms (± 0.40%)}	_~	_3,195ms	_3,230ms	_{p=0.378 n=6}
_{Req 2 - geterr}	_{1,748ms (± 0.50%)}	_{1,752ms (± 0.80%)}	_~	_1,739ms	_1,775ms	_{p=0.687 n=6}
_{Req 3 - references}	_{122ms (± 1.54%)}	_{131ms (± 8.12%)}	_{+9ms (+ 7.68%)}	_123ms	_145ms	_{p=0.019 n=6}
_{Req 4 - navto}	_{345ms (± 0.77%)}	_{345ms (± 0.83%)}	_~	_342ms	_349ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{2,862 (± 0.00%)}	_{2,862 (± 0.00%)}	_~	_2,862	_2,862	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{407ms (± 2.83%)}	_{398ms (± 0.78%)}	_~	_394ms	_402ms	_{p=0.147 n=6}
_{Compiler-UnionsTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,783ms (± 1.32%)}	_{2,797ms (± 0.52%)}	_~	_2,778ms	_2,820ms	_{p=0.378 n=6}
_{Req 2 - geterr}	_{6,334ms (± 0.32%)}	_{6,379ms (± 0.80%)}	_~	_6,295ms	_6,451ms	_{p=0.065 n=6}
_{Req 3 - references}	_{366ms (± 1.08%)}	_{368ms (± 0.57%)}	_~	_365ms	_371ms	_{p=0.418 n=6}
_{Req 4 - navto}	_{290ms (± 0.49%)}	_{291ms (± 1.34%)}	_~	_289ms	_299ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{100ms (± 5.29%)}	_{103ms (± 1.34%)}	_~	_100ms	_104ms	_{p=0.741 n=6}
_{CompilerTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,955ms (± 0.48%)}	_{2,974ms (± 0.57%)}	_~	_2,957ms	_3,006ms	_{p=0.077 n=6}
_{Req 2 - geterr}	_{4,571ms (± 0.76%)}	_{4,592ms (± 0.70%)}	_~	_4,539ms	_4,620ms	_{p=0.298 n=6}
_{Req 3 - references}	_{380ms (± 0.66%)}	_{377ms (± 0.46%)}	_~	_375ms	_380ms	_{p=0.167 n=6}
_{Req 4 - navto}	_{298ms (± 0.87%)}	_{300ms (± 0.46%)}	_~	_298ms	_301ms	_{p=0.222 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{76ms (± 0.68%)}	_{76ms (± 0.99%)}	_~	_75ms	_77ms	_{p=0.784 n=6}
_{xstateTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{3,501ms (± 0.80%)}	_{3,493ms (± 1.09%)}	_~	_3,429ms	_3,539ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{1,844ms (± 0.26%)}	_{1,850ms (± 0.62%)}	_~	_1,835ms	_1,870ms	_{p=0.228 n=6}
_{Req 3 - references}	_{147ms (± 8.55%)}	_{155ms (± 5.22%)}	_~	_139ms	_161ms	_{p=0.173 n=6}
_{Req 4 - navto}	_{394ms (± 1.07%)}	_{402ms (± 1.61%)}	_{+8ms (+ 2.03%)}	_395ms	_411ms	_{p=0.045 n=6}
_{Req 5 - completionInfo count}	_{2,862 (± 0.00%)}	_{2,862 (± 0.00%)}	_~	_2,862	_2,862	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{432ms (± 0.91%)}	_{432ms (± 1.59%)}	_~	_424ms	_442ms	_{p=0.748 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.21.3, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.21.3, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₉₆₂	₆
_Baseline	_main	₆

Startup

Comparison Report - main..53962

_Metric	_main	₅₃₉₆₂	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{141.03ms (± 0.23%)}	_{141.54ms (± 0.21%)}	_{+0.51ms (+ 0.36%)}	_140.71ms	_143.98ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{219.48ms (± 0.19%)}	_{221.05ms (± 0.21%)}	_{+1.57ms (+ 0.72%)}	_219.70ms	_225.95ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{221.33ms (± 0.22%)}	_{222.28ms (± 0.24%)}	_{+0.95ms (+ 0.43%)}	_220.92ms	_232.85ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{203.19ms (± 0.22%)}	_{204.29ms (± 0.26%)}	_{+1.10ms (+ 0.54%)}	_202.84ms	_209.35ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₉₆₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

May 03 '23 00:05 typescript-bot

I'm surprised that there are significant deltas with main. Is it perhaps because this branch is pretty outdated (or is the perf run rebasing with main before running everything)?

May 03 '23 12:05 71

I'm surprised that there are significant deltas with main. Is it perhaps because this branch is pretty outdated (or is the perf run rebasing with main before running everything)?

All CI runs on the merge-head, which is main + the PR. That being said, there inherent noise.

@typescript-bot perf test this faster

May 03 '23 23:05 jakebailey

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at de96190401979ebebbc7089fe5ac87673f1a6191. You can monitor the build here.

Update: The results are in!

May 03 '23 23:05 typescript-bot

@jakebailey The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53962

_Metric	_main	₅₃₉₆₂	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,245k (± 0.01%)}	_{365,285k (± 0.01%)}	_{+41k (+ 0.01%)}	_365,244k	_365,324k	_{p=0.036 n=6}
_{Parse Time}	_{3.56s (± 0.88%)}	_{3.55s (± 0.39%)}	_~	_3.54s	_3.57s	_{p=0.745 n=6}
_{Bind Time}	_{1.18s (± 0.44%)}	_{1.18s (± 0.44%)}	_~	_1.18s	_1.19s	_{p=0.069 n=6}
_{Check Time}	_{9.61s (± 0.61%)}	_{9.57s (± 0.51%)}	_~	_9.51s	_9.64s	_{p=0.292 n=6}
_{Emit Time}	_{7.97s (± 0.72%)}	_{7.93s (± 0.57%)}	_~	_7.88s	_8.00s	_{p=0.172 n=6}
_{Total Time}	_{22.32s (± 0.48%)}	_{22.24s (± 0.22%)}	_~	_22.15s	_22.28s	_{p=0.145 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,691k (± 0.01%)}	_{192,712k (± 0.04%)}	_~	_192,632k	_192,812k	_{p=0.688 n=6}
_{Parse Time}	_{1.59s (± 1.42%)}	_{1.59s (± 0.92%)}	_~	_1.57s	_1.61s	_{p=0.870 n=6}
_{Bind Time}	_{0.83s (± 0.90%)}	_{0.82s (± 0.99%)}	_~	_0.81s	_0.83s	_{p=0.120 n=6}
_{Check Time}	_{10.38s (± 0.21%)}	_{10.30s (± 0.68%)}	_~	_10.21s	_10.40s	_{p=0.077 n=6}
_{Emit Time}	_{3.02s (± 0.41%)}	_{3.04s (± 0.64%)}	_{+0.02s (+ 0.77%)}	_3.01s	_3.06s	_{p=0.050 n=6}
_{Total Time}	_{15.81s (± 0.29%)}	_{15.75s (± 0.43%)}	_~	_15.68s	_15.85s	_{p=0.147 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,851k (± 0.00%)}	_{345,865k (± 0.00%)}	_~	_345,851k	_345,888k	_{p=0.149 n=6}
_{Parse Time}	_{2.73s (± 0.51%)}	_{2.72s (± 0.33%)}	_~	_2.71s	_2.73s	_{p=0.357 n=6}
_{Bind Time}	_{1.09s (± 0.47%)}	_{1.09s (± 0.58%)}	_~	_1.08s	_1.10s	_{p=0.386 n=6}
_{Check Time}	_{7.88s (± 0.44%)}	_{7.91s (± 0.63%)}	_~	_7.86s	_7.98s	_{p=0.687 n=6}
_{Emit Time}	_{4.50s (± 1.01%)}	_{4.47s (± 0.90%)}	_~	_4.42s	_4.53s	_{p=0.228 n=6}
_{Total Time}	_{16.20s (± 0.50%)}	_{16.18s (± 0.40%)}	_~	_16.08s	_16.28s	_{p=0.520 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,123k (± 0.01%)}	_{300,132k (± 0.01%)}	_~	_300,109k	_300,155k	_{p=0.295 n=6}
_{Parse Time}	_{2.14s (± 0.48%)}	_{2.16s (± 0.68%)}	_~	_2.14s	_2.17s	_{p=0.094 n=6}
_{Bind Time}	_{1.24s (± 0.72%)}	_{1.24s (± 0.61%)}	_~	_1.23s	_1.25s	_{p=0.798 n=6}
_{Check Time}	_{7.29s (± 0.32%)}	_{7.28s (± 0.41%)}	_~	_7.25s	_7.33s	_{p=0.686 n=6}
_{Emit Time}	_{4.39s (± 0.93%)}	_{4.38s (± 0.63%)}	_~	_4.34s	_4.42s	_{p=0.808 n=6}
_{Total Time}	_{15.06s (± 0.21%)}	_{15.06s (± 0.34%)}	_~	_15.00s	_15.14s	_{p=0.872 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,588k (± 0.01%)}	_{481,610k (± 0.01%)}	_~	_481,549k	_481,651k	_{p=0.810 n=6}
_{Parse Time}	_{3.25s (± 0.45%)}	_{3.24s (± 0.28%)}	_~	_3.23s	_3.25s	_{p=0.164 n=6}
_{Bind Time}	_{0.94s (± 0.43%)}	_{0.94s (± 0.80%)}	_~	_0.93s	_0.95s	_{p=0.389 n=6}
_{Check Time}	_{17.93s (± 0.35%)}	_{17.86s (± 0.20%)}	_~	_17.80s	_17.90s	_{p=0.053 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.13s (± 0.30%)}	_{22.04s (± 0.15%)}	_{-0.09s (- 0.38%)}	_21.98s	_22.07s	_{p=0.045 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{560,400k (± 0.01%)}	_{560,442k (± 0.02%)}	_~	_560,305k	_560,543k	_{p=0.378 n=6}
_{Parse Time}	_{3.99s (± 0.53%)}	_{3.99s (± 0.37%)}	_~	_3.98s	_4.02s	_{p=1.000 n=6}
_{Bind Time}	_{1.77s (± 0.00%)}	_{1.75s (± 0.43%)}	_{-0.02s (- 1.04%)}	_1.74s	_1.76s	_{p=0.003 n=6}
_{Check Time}	_{3.07s (± 0.89%)}	_{3.06s (± 0.45%)}	_~	_3.05s	_3.09s	_{p=0.868 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.92s (± 0.47%)}	_{8.90s (± 0.22%)}	_~	_8.88s	_8.93s	_{p=0.419 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₉₆₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

May 03 '23 23:05 typescript-bot

The results look like noise. On the other hand, control flow changes can slow down the binder (more allocation) and the checker (more nodes to iterate over).

May 04 '23 16:05 sandersn

However, the bug still needs to be accepted for us to review this. Knowing that the change isn't horribly slow helps make the case for it, but it's marked "Awaiting More Feedback", which means that we're waiting for more people to agree that they need this and add more examples of usage.

May 04 '23 16:05 sandersn

To help with PR housekeeping, I'm going to close this PR since it's pretty old now. We can reopen and merge with main if its bug gets accepted.

Dec 06 '23 00:12 sandersn

TypeScript TypeScript copied to clipboard

Support control flow analysis for tagged template calls

Compiler

TSServer

Startup

TypeScript
TypeScript copied to clipboard