TypeScript Fix `isGenericReducibleType` to allow HKT technique to function again

Fixes #53970.

May 03 '23 15:05 ahejlsberg

@typescript-bot test this @typescript-bot user test this inline @typescript-bot run dt @typescript-bot perf test faster @typescript-bot test top100

May 03 '23 15:05 ahejlsberg

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at dd882290801573e05d412e9a140ad9875e736e50. You can monitor the build here.

Update: The results are in!

May 03 '23 15:05 typescript-bot

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at dd882290801573e05d412e9a140ad9875e736e50. You can monitor the build here.

Update: The results are in!

May 03 '23 15:05 typescript-bot

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at dd882290801573e05d412e9a140ad9875e736e50. You can monitor the build here.

Update: The results are in!

May 03 '23 15:05 typescript-bot

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at dd882290801573e05d412e9a140ad9875e736e50. You can monitor the build here.

Update: The results are in!

May 03 '23 15:05 typescript-bot

Heya @ahejlsberg, I've started to run the extended test suite on this PR at dd882290801573e05d412e9a140ad9875e736e50. You can monitor the build here.

May 03 '23 15:05 typescript-bot

@ahejlsberg The results of the perf run you requested are in!

Here they are:

Comparison Report - main..54112

_Metric	_main	₅₄₁₁₂	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,264k (± 0.01%)}	_{365,259k (± 0.01%)}	_~	_365,229k	_365,318k	_{p=0.688 n=6}
_{Parse Time}	_{3.53s (± 0.77%)}	_{3.55s (± 0.56%)}	_~	_3.52s	_3.58s	_{p=0.224 n=6}
_{Bind Time}	_{1.17s (± 0.44%)}	_{1.17s (± 0.47%)}	_~	_1.17s	_1.18s	_{p=0.640 n=6}
_{Check Time}	_{9.58s (± 0.57%)}	_{9.60s (± 0.44%)}	_~	_9.52s	_9.63s	_{p=0.747 n=6}
_{Emit Time}	_{7.92s (± 0.82%)}	_{7.95s (± 0.80%)}	_~	_7.86s	_8.02s	_{p=0.335 n=6}
_{Total Time}	_{22.20s (± 0.55%)}	_{22.28s (± 0.32%)}	_~	_22.18s	_22.38s	_{p=0.199 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,729k (± 0.05%)}	_{192,777k (± 0.03%)}	_~	_192,686k	_192,836k	_{p=0.378 n=6}
_{Parse Time}	_{1.59s (± 0.95%)}	_{1.59s (± 0.34%)}	_~	_1.59s	_1.60s	_{p=0.865 n=6}
_{Bind Time}	_{0.82s (± 0.00%)}	_{0.82s (± 0.63%)}	_~	_0.82s	_0.83s	_{p=0.174 n=6}
_{Check Time}	_{10.30s (± 0.29%)}	_{10.29s (± 0.35%)}	_~	_10.25s	_10.35s	_{p=0.685 n=6}
_{Emit Time}	_{2.99s (± 0.44%)}	_{3.02s (± 0.93%)}	_{+0.04s (+ 1.23%)}	_3.00s	_3.07s	_{p=0.014 n=6}
_{Total Time}	_{15.71s (± 0.25%)}	_{15.74s (± 0.38%)}	_~	_15.68s	_15.84s	_{p=0.331 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,841k (± 0.01%)}	_{345,853k (± 0.01%)}	_~	_345,827k	_345,888k	_{p=1.000 n=6}
_{Parse Time}	_{2.70s (± 0.30%)}	_{2.72s (± 0.39%)}	_~	_2.70s	_2.73s	_{p=0.078 n=6}
_{Bind Time}	_{1.08s (± 1.31%)}	_{1.08s (± 0.38%)}	_~	_1.08s	_1.09s	_{p=0.858 n=6}
_{Check Time}	_{7.86s (± 0.53%)}	_{7.89s (± 0.29%)}	_~	_7.85s	_7.91s	_{p=0.293 n=6}
_{Emit Time}	_{4.46s (± 0.39%)}	_{4.47s (± 0.61%)}	_~	_4.45s	_4.51s	_{p=0.624 n=6}
_{Total Time}	_{16.11s (± 0.33%)}	_{16.16s (± 0.32%)}	_~	_16.09s	_16.22s	_{p=0.102 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,127k (± 0.01%)}	_{300,115k (± 0.01%)}	_~	_300,085k	_300,132k	_{p=0.336 n=6}
_{Parse Time}	_{2.15s (± 0.38%)}	_{2.15s (± 0.42%)}	_~	_2.14s	_2.16s	_{p=0.550 n=6}
_{Bind Time}	_{1.23s (± 0.66%)}	_{1.24s (± 0.94%)}	_~	_1.22s	_1.25s	_{p=0.401 n=6}
_{Check Time}	_{7.29s (± 0.46%)}	_{7.29s (± 0.75%)}	_~	_7.22s	_7.36s	_{p=0.688 n=6}
_{Emit Time}	_{4.38s (± 0.55%)}	_{4.37s (± 1.01%)}	_~	_4.32s	_4.45s	_{p=0.250 n=6}
_{Total Time}	_{15.05s (± 0.36%)}	_{15.05s (± 0.58%)}	_~	_14.91s	_15.16s	_{p=1.000 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,585k (± 0.01%)}	_{481,651k (± 0.01%)}	_{+66k (+ 0.01%)}	_481,593k	_481,712k	_{p=0.031 n=6}
_{Parse Time}	_{3.24s (± 0.16%)}	_{3.25s (± 0.23%)}	_{+0.01s (+ 0.36%)}	_3.24s	_3.26s	_{p=0.020 n=6}
_{Bind Time}	_{0.94s (± 0.55%)}	_{0.94s (± 0.87%)}	_~	_0.93s	_0.95s	_{p=0.929 n=6}
_{Check Time}	_{17.93s (± 0.41%)}	_{17.84s (± 0.62%)}	_~	_17.70s	_18.03s	_{p=0.199 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.11s (± 0.36%)}	_{22.03s (± 0.49%)}	_~	_21.89s	_22.21s	_{p=0.298 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{560,337k (± 0.01%)}	_{560,426k (± 0.02%)}	_~	_560,312k	_560,537k	_{p=0.298 n=6}
_{Parse Time}	_{3.99s (± 0.21%)}	_{3.99s (± 0.33%)}	_~	_3.97s	_4.01s	_{p=0.803 n=6}
_{Bind Time}	_{1.76s (± 0.66%)}	_{1.76s (± 0.59%)}	_~	_1.75s	_1.78s	_{p=0.619 n=6}
_{Check Time}	_{3.06s (± 0.55%)}	_{3.06s (± 0.67%)}	_~	_3.05s	_3.09s	_{p=0.806 n=6}
_{Emit Time}	_{0.09s (± 4.45%)}	_{0.09s (± 4.62%)}	_~	_0.08s	_0.09s	_{p=0.218 n=6}
_{Total Time}	_{8.90s (± 0.17%)}	_{8.91s (± 0.24%)}	_~	_8.89s	_8.94s	_{p=0.368 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₁₁₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

May 03 '23 15:05 typescript-bot

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/54112/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Everything looks good!

May 03 '23 16:05 typescript-bot

@typescript-bot pack this

May 03 '23 16:05 jakebailey

Heya @jakebailey, I've started to run the tarball bundle task on this PR at dd882290801573e05d412e9a140ad9875e736e50. You can monitor the build here.

May 03 '23 16:05 typescript-bot

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/153735/artifacts?artifactName=tgz&fileId=86B63ABAABD7BD283E61F4D0A8D4ABF9480EC038270693BC271390E9F9FBE3A202&fileName=/typescript-5.1.0-insiders.20230503.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

May 03 '23 16:05 typescript-bot

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/54112/merge:

Everything looks good!

May 03 '23 17:05 typescript-bot

Hey @ahejlsberg, the results of running the DT tests are ready. Everything looks the same! You can check the log here.

May 03 '23 17:05 typescript-bot

@ahejlsberg nice, i confirm that zodios use case is working again : link to playground

May 03 '23 19:05 ecyrbe

Amazing thank you!

May 03 '23 20:05 mikearnaldi

It seems that it is only partially resolved though, while inference work the signature after map(typeClass) is not resolved, that will make all the inferred types painful to use when the resulting function is not immediately applied.

Screenshot 2023-05-03 211018

May 03 '23 20:05 mikearnaldi

Latest commit reverts the changes to type inference and instead fixes the issue by making isGenericReducibleType more conversative. The previous logic would wrongly classify TTypeLambda & { readonly A: A; } as being reducible even though there are no discriminant properties in the type. That's now fixed.

May 05 '23 00:05 ahejlsberg

@typescript-bot test this @typescript-bot user test this inline @typescript-bot run dt @typescript-bot perf test faster @typescript-bot test top100

May 05 '23 00:05 ahejlsberg

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 64a864b4d5a48e5a56e6a1199e687efaa13181c9. You can monitor the build here.

Update: The results are in!