Jake Bailey
Jake Bailey
It's not blocked, it's just not implemented yet.
This is a side effect of us switching to `json/v2`, which will error when trying to send strings that are not UTF-8 safe. In our case, our internal symbol names...
That's not okay, because they will look like real names. We should likely instead convert them to something more like the old code with double underscores or similar. But simply...
I'm thinking about it. Maybe for now we just do the hotfix and make sure `BuildInfoDiagnostic`, `buildInfoDiagnosticWithFileName`, `buildInfoDiagnosticWithFileName`, replace `ast.InternalSymbolNamePrefix` with `__`.
That or, we put JSON marshalling in compat mode for this one difference in buildinfo, but that won't work for other stuff in the LSP.
Yeah, I forgot that we reproduce the errors too ☹️ I have a branch where I've changed the internal prefix to something we can roundtrip, but I'm not 100% certain...
Of course, internal symbols _ever_ appearing in public anything are bugs. (In the API, that's okay, but not so much elsewhere.) We also have some internal symbols that use a...
I have access to this repo, but will need to reclone and so on...
Do you have a self contained example we could test?
Oh boy, I wonder how much this conflicts with the existing trusted types that people are using...