Jake Bailey comments

Results 1405 comments of


                                            Jake Bailey

Use `go test -json` in updateFailing, detect baseline errors

I need to think about this harder; I have to go manually merge this into one of my branches to get it to test so it's annoying to figure out.

Use `go test -json` in updateFailing, detect baseline errors

No, this does seem to work, I just merged the two PRs together wrong.

typeof json file with import panic: Unhandled case in Node.Expression (only occurs when using VSCode LSP, tsgo CLI works fine)

It's not, no. Thanks for the issue.

Update lsp generation for more accurate documentation

> I noticed that when I re-ran the generation, I got different results than the currently committed file This shouldn't be possible; the script is deterministic. Did you run the...

Update lsp generation for more accurate documentation

Merging #789 and rerunning CI here shows that the formatting is in fact being changed in an unexpected way.

Revamp user preferences serialization/deserialization

I think I'm going to wait for the other two user pref related PRs to finish and just fix this PR instead of forcing that on everyone.

Add missing type definitions for package `probe-image-size` deep imports.

One last question; these entrypoints are not documented by the package at all. Are they intended to be imported like this?

Fix empty wildcard match on exports

Is there a test you can make for this? The fix seems obviously right, however. The original code looked more like: ```ts case MatchingMode.Pattern: const starPos = pathOrPattern.indexOf("*"); const leadingSlice...

Fix empty wildcard match on exports

> Interestingly the original code looks like it may be subtly incorrect as well. It won't crash due to JS's more lenient slice() but it does have the false positive...

fix(types): fixed `Fixtures` type to disambiguite between intersected mapped types

Per the linked issue, this only works if downstream users use TS 5.6+, right?