James Kominick

Results 104 comments of James Kominick

thanks @jqnatividad ! Would you mind resolving the cargo toml conflicts - and also reverting the space alignment (I don't like having to update a bunch of lines to fix...

Sorry about that. I haven't had a chance to fix the binary packaging. It was originally using travis-ci, and I need to convert it over to github actions

It's not currently possible, but I'd be happy to accept a PR if you can get to it before I have time to work on it. It would be pretty...

This is currently working as intended, but I understand the desire to only synchronize on a per key basis. Support for this could be added (preferably behind another macro arg...

The effect of that option is here: when true, the lock is just held for the function execution instead of being released for others to read https://github.com/jaemk/cached/blob/f1bcfd6e7611e817c2c7f95a0fafc002f38880a6/cached_proc_macro/src/cached.rs#L236

If you want to clear expired items, the timed and timed-sized stores have a flush method to do so: https://docs.rs/cached/latest/cached/struct.TimedSizedCache.html#method.flush. I don’t want to add functionality beyond that though since...

Can you make this a pair of features to enable either ureq or reqwest? If someone already has tokio in their dep tree, they may prefer using reqwest over depending...

@Chloe-Woahie thanks for pointing this out. The Error variants definitely need some documentation. A PR is welcome if you have time before I do

Sorry pretty late to the party here - that comment is correct, the contents of the migration are batch executed as is (whether or not you compiled with the `d-postgres`...