James Kominick

Results 104 comments of James Kominick

The github api returns json to basic get requests. You have to set `Accept: application/octet-stream` to get back the contents of the release (which happens [here](https://github.com/jaemk/self_update/blob/3d522e87d714c41f77c33cc50573567546da1774/src/update.rs#L217])): ``` james@tamale|t.main:~/bin$ ::: curl...

It'd be helpful if you could modify your code to use the example code linked to in https://github.com/jaemk/self_update/issues/81#issuecomment-1019003981, modify the final `Move::from_source` to write to some other file, and then...

That's... Interesting. And if you replace the contents of that update function with a call to the GitHub updater, then it spits out an empty file again?

Ah, yeah that'll do it! Glad you were able to get to the bottom of it. Maybe it was the same thing affecting @Nickhoyer

@tjyang I think the issue is that your github releases (https://github.com/tjyang/rustgb_self_update/releases) are missing the expected assets. The example releases here (https://github.com/jaemk/self_update/releases) have assets named by the arch they are intended...

This is to mirror what cargo-update considers a compatible bump. For versions < 1.0.0, minor changes 0.2.0 -> 0.3.0 are considered breaking in the same way changes from 1.0.0 ->...

Yeah that would be possible. Would you mind describing a bit more how you would expect that to work?

Yes, definitely would be a good addition!

Thanks for the suggestions and quesions @jqnatividad and @tirithen! There's a been good amount of thinking in this thread about how the disk writes should be handled and how the...

I'd be open to adding a config option to use either `ureq` or `reqwest`. I'd imagine some people might want to continue using `reqwest` if they are already using it...