James Kominick

Results 104 comments of James Kominick

Thanks for reviewing, @syrusakbary! `ast_from_value`/`value_from_ast` are updated now, along with a couple more tests. I believe there's already a test for checking that null is allowed as a field name...

@pbeckham I've been sitting on some more changes, I'll push those later today. The last issue I think I'm down to is dealing with null default values during schema introspection

@syrusakbary I think I've checked all the boxes. Mind taking another look?

@syrusakbary - checking in to see if there's anything else I can do

For distributing my cli apps I made https://github.com/jaemk/self_update to support a "self update" command that pulls the latest github release built using https://github.com/japaric/trust/

I personally like to use [tera](https://docs.rs/tera/0.10/tera/). But whatever template engine you use, you just render your template to a string and then pass that string along to `Response::html`. For example,...

If you're interested in using tera, I recommend looking at the main [example](https://github.com/Keats/tera/tree/master/examples). You could then use the snippet I previously mentioned inside the handler.

The performance gains from this PR are really impressive! Running the `hello-world` example goes from 19k req/s to 83k req/s (with `wrk -t4 -c100 -d10s`) I did notice two issues...

closing in favor of #127

@jacderida Thanks for pointing this out. I see what you're saying, and I see that running the github example says it's going to download from the "asset" url instead of...