jaehanbyun

Results 13 comments of jaehanbyun

> It seems this issue has been fixed in this PR: https://github.com/argoproj/argo-cd/pull/20181/files. I checked it, Thanks!

@linghaoSu As you mentioned, when I change the browser language settings, the sorting does not work properly. May I work on addressing this issue?

Hello, @nitishfy. I have reviewed what you mentioned. I will address the issue and submit a new PR shortly. Thank you!

Hello, @crenshaw-dev. What do you think about this feature? If you think it's a good idea, I'd like to try working on it. Thank you.

@skoeva Updated the `getPorts` implementation as suggested. Thanks a lot for the review!

@skoeva Sorry for the late reply. I’ve rebased the branch and applied the requested changes. Could you please take a look ?

@Vad1mo Got it, I’ll update the diagram in draw.io.

@illume Thanks for the review! I tested concurrent edits to answer your question: - Different fields (e.g., different label keys): both updates apply successfully. - Same field (same label key,...

@illume Yeah, handling the three cases as you described would definitely provide a better UX. So, before implementing it, I think we should follow an approach(3 ver diff) like this:...