argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

fix(docs): ensure version dropdown sorts correctly regardless of browser language #20289

Open jaehanbyun opened this issue 1 year ago • 2 comments

Closes #20289

Checklist:

  • [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [ ] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] The title of the PR conforms to the Toolchain Guide
  • [X] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ ] Does this PR require documentation updates?
  • [X] I've updated documentation as required by this PR.
  • [X] I have signed off all my commits as required by DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My build is green (troubleshooting builds).
  • [ ] My new feature complies with the feature status guidelines.
  • [ ] I have added a brief description of why this PR is necessary and/or what this PR solves.
  • [ ] Optional. My organization is added to USERS.md.
  • [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

What I have done:

I resolved an issue where 'version' was hardcoded, preventing proper sorting in browsers set to languages other than English. The screenshot below shows that it now operates correctly in a browser set to German. image

jaehanbyun avatar Oct 10 '24 07:10 jaehanbyun

:x: Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • :rocket: /bns:deploy to deploy the environment

bunnyshell[bot] avatar Oct 10 '24 07:10 bunnyshell[bot]

Hello, @nitishfy.

I have reviewed what you mentioned. I will address the issue and submit a new PR shortly. Thank you!

jaehanbyun avatar Oct 10 '24 09:10 jaehanbyun