Results 34 comments of Jacob Vosmaer

@pravi asked me (gitlab-workhorse maintainer) to comment here but I don't know what to do either. @pravi raven-go provides an optional feature in gitlab-workhorse. As long as gitlab-workhorse compiles on...

This looks like a taglib problem, I can reproduce it at that level. ```c++ #include #include int main(int argc, char **argv) { if (argc != 2) { std::cout

Thanks for posting an issue upstream @jangler.

This may be a taglib question rather than a taglib-ruby question. Does the thing you want to do work when you call taglib from C++? Jacob Vosmaer > On 21...

Ughh... @DouweM could you create separate issues for the differences? I think it would be really nice to stamp these out.

@DouweM the converter does all sorts of things on purpose; it is just that those things were put there by the lanyrd developers, not by us. :)

It would be nice to also have a regression test for this. What do you think, @jacargentina?

I think this might be the problem: https://github.com/robinst/taglib-ruby/blob/189fa6b1147025bc907a1119c1e8df57f70df822/ext/taglib_mpeg/taglib_mpeg.i#L60-L71 When the `TagLib::MPEG::File.open` block is done, Ruby may garbage-collect the `TagLib::MPEG::File` instance used by the block. That instance has a cleanup function...

@robinst looking at the [SWIG documentation](https://www.swig.org/Doc4.1/Ruby.html#Ruby_nn61) I wonder if we should move away from this pattern of using `%freefunc` and use `%markfunc` instead. If we use `%markfunc` correctly then we...

>Ruby may garbage-collect In fact, closing the file forces freeing of the objects: https://github.com/robinst/taglib-ruby/blob/189fa6b1147025bc907a1119c1e8df57f70df822/ext/taglib_mpeg/taglib_mpeg.i#L87-L89