raven-go icon indicating copy to clipboard operation
raven-go copied to clipboard

support building with gccgo

Open pravi opened this issue 7 years ago • 3 comments

gccgo is the only available go compiler for powerpc and I'd like to have gitlab-workhorse built with raven-go but fails tests when built with gccgo. Details here http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=842897

Please support building with gccgo.

pravi avatar Nov 02 '16 09:11 pravi

I'm not sure what the issue here is and I've never used gccgo, so some help here would be appreciated.

Is gccgo mangling stuff when it compiles? It just seems that the stack information is different. But I'm hesitant to change, since due to the nature of this library, we literally are testing the ability to extract this information correctly.

mattrobenolt avatar Nov 02 '16 10:11 mattrobenolt

I don't know gccgo well enough to answer this. I have asked a few people to help me with bug. Hope one of them will comment here.

pravi avatar Nov 02 '16 10:11 pravi

@pravi asked me (gitlab-workhorse maintainer) to comment here but I don't know what to do either.

@pravi raven-go provides an optional feature in gitlab-workhorse. As long as gitlab-workhorse compiles on gccgo, and as long as the end user is not trying to enable Sentry in gitlab-workhorse on powerpc, perhaps you could ignore this problem.

jacobvosmaer avatar Nov 03 '16 14:11 jacobvosmaer