Jacob Walls

Results 222 comments of Jacob Walls

Hi @GeyseR, if you've accounted for all feedback to date you should uncheck "Needs tests" and "Patch needs improvement" on the ticket so that there's an indication to re-review it....

Hi @ethanhowell, I can give you a tip for moving this along -- uncheck Needs Tests and Needs Improvement on the underlying ticket to get back in the review queue...

Hi @KimSoungRyoul, if this is ready for re-review, please uncheck "Needs improvement" on the Trac ticket, which is how we track waiting-for-author. While here, I noticed the release notes and...

Hi @horpto, thanks for this. Would you open a [ticket](https://code.djangoproject.com/newticket) for this proposal? All behavior changes need an accepted ticket.

Don't forget to keep the "Needs..." flags on the ticket up to date, otherwise your PR won't be visible in the review queue.

The checkboxes on the ticket. Just log in to Trac (presumably with your GitHub creds) and you'll see the last action on the ticket was when a reviewer used those...

Oh sorry, didn't see you included a screenshot. Uncheck "needs tests" and "patch needs improvement" and save your changes.

Howdy @horpto, if you want to flesh this out could you open a ticket? That's how we get eyes on things. I'm skeptical at first glance. It looks a lot...