django
django copied to clipboard
django
Fixed#32398--Fixed negated annotation filter on build_filter
I fixed the reported bug. but when the driving table has left join, I can't handle it right now. it is difficult on the current structure. (this code -> self.alias_map[join_list[-1]].join_type == LOUTER)) If there are any issues, please tell me. and frankly, I don't know where is the good place to put the test code...
Don't forget to keep the "Needs..." flags on the ticket up to date, otherwise your PR won't be visible in the review queue.
The checkboxes on the ticket. Just log in to Trac (presumably with your GitHub creds) and you'll see the last action on the ticket was when a reviewer used those boxes to indicate tests and improvements still needed. If you're caught up on review feedback, it's time to let people know on the ticket by unsetting the flags.
Oh sorry, didn't see you included a screenshot. Uncheck "needs tests" and "patch needs improvement" and save your changes.
@jacobtylerwalls I think i seem to miss something.(to receive review) If you know about this, please let me know.
@baidoosik Thanks for updates :+1: You didn't miss anything. There are ~30 PRs waiting for a review, please be patient.
@felixxm Sorry I didn't rush you. It was my first time to open source, so I misunderstood because I didn't know the process well! Thank you for your answer!!
Can we also add a test for a nullable subquery annotation (see ticket-32684 that was marked as a duplicate)?
Hello @baidoosik! I'm doing some PR cleanup. Would you have time to keep working on this? Specifically, if you could rebase onto the latest main, and also resolve conflicts, that would be great. I can then try to push further the review process, since it seems quite advanced already.
Thank you!
@nessita Hi ~! sorry for late response. i think it's hard to keep this PR. You can close this. i will try to make new PR when i have a enough time. Thanks for asking!