Jacob Perron

Results 258 comments of Jacob Perron

Sorry, I won't have the time to continue working on this any time soon. Feel free to close or take over the PR.

> Should we expose the API's for ImageFocalLengthX(), ImageOpticalCentreX() etc in CameraSensor similar to ImageWidth() and ImageHeight() API's? Maybe, I'm not sure of the scenario where this might be required....

After reviewing the discussion above, I lean towards the position that we shouldn't allow `$(param ...)` substitutions. > > The only case where this solution could do something that an...

> Maybe the GoalHandle should be inserted when sending the goal request and not when receiving the goal response to avoid the race. We should be careful with this, since...

> There are some examples here: > > https://design.ros2.org/articles/actions.html#clientserver-interaction-examples > > But all of them indicate feedback is sent after the result request is received. I don't think we need...

> I was thinking that if you ensure the client immediately requests a response then that could tell you for sure the client has received the goal response, but that...

#1684 looks okay to me, but I'm not convinced it will actually improve the situation since there's no guarantee on the arrival order of messages. Really, we need to answer:...

Closing since this has been open for a long time without any activity.

I think it would be better if the tutorial code was actually built as part of this repository. I suggest making it a sibling of the image_transport package so that...

I'm interested in playing with this, but am also having a problem starting the demo. I suspect it's because I'm using node v0.11.3? (and the master branch is only compatible...