jacobg

In getModel() method: 1) The call to Ext.ModelManager.get should be Ext.ModelManager.getModel. 2) It defines SlideNavigationPanelItem model class as a global variable via Ext.define. That is bad practice to pollute the...

Examples: ```python >>> pendulum.datetime(2020, 12, 1) + pendulum.parse('P1M') DateTime(2021, 1, 1, 0, 0, 0, tzinfo=Timezone('UTC')) >>> pendulum.datetime(2021, 1, 1) - pendulum.datetime(2020, 12, 1) == pendulum.parse('P1M') False >>> pendulum.datetime(2020, 12, 31)...

Incorrect duration parsing logic with decimals

1

```python >>> pendulum.parse('PT16M') Duration(minutes=16) # GOOD! >>> pendulum.parse('PT16.4M') Duration(minutes=16, seconds=24) # GOOD! >>> pendulum.parse('PT16.48M') Duration(minutes=20, seconds=48). # BAD! Should be: Duration(minutes=16, seconds=28, milliseconds=800) ``` The first two cases above have...

Error parsing ISO8601 duration with negative sign

1

For example, `-PT8H` is a valid IOS 8601 duration. But pendulum raises an error when trying to parse it. ```python >>> pendulum.parse('-PT8H') Traceback (most recent call last): File "", line...

Please add duration total_microseconds() method.

A timedelta stores microseconds as an int, whereas pendulum.duration is storing as a float. ```python >>> datetime.timedelta(0, 5, 499385).microseconds 499385 >>> pendulum.duration(0, 5, 499385).microseconds 499385.0 ``` This subtle difference can...

Fails if key is an int

1

A dictionary such as: ``` {1: "abc"} ``` will fail with this exception: ``` File "/env/lib/python3.7/site-packages/animal_case/__init__.py", line 72, in parse_keys formatted[key] = parse_keys(value, types) File "/env/lib/python3.7/site-packages/animal_case/__init__.py", line 70, in parse_keys...

A couple suggestions

1

Good job. I'm about to integrate it into my project. A few suggestions (which I plan to do on my own): 1) rather than shutdown after maxInactive interval, instead store...

Make caching layer compatible with ndb

2

Google has a Python datastore client calling NDB that supports caching: https://github.com/googleapis/python-ndb It would be great if this node library's caching implementation were compatible with NDB to enable polyglot microservices.

Key datastore property bleeds into typescript Type

11

Following the documentation on using gstore-node with Typescript, I had to define a custom Type which has a key property in the following way: ```ts type ChildType = { //...