sencha-SlideNavigation icon indicating copy to clipboard operation
sencha-SlideNavigation copied to clipboard

A couple bugs with getModel() method

Open jacobg opened this issue 10 years ago • 0 comments

In getModel() method:

  1. The call to Ext.ModelManager.get should be Ext.ModelManager.getModel.

  2. It defines SlideNavigationPanelItem model class as a global variable via Ext.define. That is bad practice to pollute the global namespace. A better way to set the model name would be like this:

var className = this.self.getName(),
    model = className.substr(0, className.lastIndexOf('.')) + '.SlideNavigationPanelItem';

jacobg avatar Jan 22 '15 17:01 jacobg