Jacob Gilbert

Results 72 comments of Jacob Gilbert

I've been working with this a little more and I think that almost all use cases could be addressed by allowing LENGTH type fields as variables when specifying field start/end...

@andynoack - I have currently been doing exactly what you have suggested, but there are some real limitations doing this when you have many or unpredictable length values. Mostly that...

I think this makes a lot of sense, thank you for the input. I'm going to take a look at this in my spare time; if anything comes to you...

Alternatively: ```diff diff --git a/src/inputsource.cpp b/src/inputsource.cpp index fd90020aaf..f5263ea920 100644 --- a/src/inputsource.cpp +++ b/src/inputsource.cpp @@ -298,13 +298,8 @@ void InputSource::openFile(const char *filename) annotationList.clear(); QString metaFilename; - if (suffix == "sigmf-meta") {...

Ive been using this for a while and its pretty convenient. I ended up changing the PR to use the simplified version above ^

@miek this is a good very simple PR that would be nice to have; i've been operating with this for quite a while now with no issues.

This is something that will most likely need to wait on sigmf v1.0 and the corresponding libsigmf release, where the core issue (a now obsolete `annotation` field) will be addressed....

@miek yea this is not a proud point for sigmf...it was adopted without official support. There exists a tremendous amount of `core:description` labeled datasets out there though, so IMO it...

@schneider42 Here is what I am doing on my fork: https://github.com/jacobagilbert/inspectrum/commit/b40042899b88f4b6812e4866010fdc6f56078651

@miek very simple change, low impact and I have been using this for a while with no issues, would be great to merge this.