Jack Lovell

Results 54 comments of Jack Lovell

Another couple of requests, more specific to Github: - Issue template. - PR template, including checklist of items to satisfy before submission.

Yeah, this is sensible. We build Cherab wheels for PyPI using Numpy 1.x too (using the now-deprecated oldest-supported-numpy package), so will have the same problem. We can switch to specifying...

I would support this once volumetric emitters are implemented: it's come up a couple of times in discussions at ORNL and the performance benefits and polarisation support are compelling. It...

Building with Numpy 2.0 provides backwards compatibility with runtime 1.x. So I think it'd actually be better to update `pyproject.toml` to use `numpy~=2.0` for Python 3.9 and later, and `oldest-supported-numpy`...

`theme_overrides.css` has been there since at least 2017: I don't know whether it's still necessary or whether the problem it was working around has been solved upstream in sphinx-rtd-theme since....

Neither bolometer foils nor AXUV diodes actually provide spectrally-resolved measurements. I would avoid adding spectral pipelines to the Cherab bolometers and this will result in physically-unrealisable measurements. I do however...

Ah, I see. In that case I think you can just replace `BolometerFoil.pipelines` with a list which includes a `SpectralPowerPipeline0D` instead of `PowerPipeline0D`. The `pipelines` property is user-writable for all...

Yes. Setting any of the parameters after creating the `BolometerFoil` object will override the default values. This is the encouraged way to configure observers in Cherab. You may wish to...

It's currently necessary to add all the lines you want individually, using `cherab.core.atomic.Line` and specifying the element, charge and transition. However, a utility function which would scan for and add...

2.0 is the appropriate place to remove deprecations, agreed. Have you checked if there are any public attributes or methods in classes which use the new `Targeted` spelling? For subclasses...