Jack Lovell

How about letting the user pass in a custom `metadata_parser` function object: ```python def parse_adf15(element, change, adf_file_path, metadata_parser=None): ... ``` When the value is `None` make a best-effort guess at...

PEP497 was rejected, so I don't think we should be following this route. I think if the benefits of the change are significant enough then it may be worth breaking...

I'm on board with this. We do a similar thing in cherab-mastu and cherab-jet with the `CHERAB_CADMESH` environment variable. Two things: 1. `CHERAB_OPENADAS_DEFAULT_REPOSITORY_PATH` is a bit of a mouthful. Perhaps...

I think this is a good idea. We already have some unit tests for lineshapes, but it would be good to check when doing this re-factor that the coverage is...

We now recommend the use of Raysect's interpolators, which don't have this issue. All internal uses of the interpolators in Cherab were swapped to Raysect ones in #304. The existing...

As above, it doesn't make sense to map SOL/PFR quantities to the equilibrium: the relavant quantities are not flux functions outside the LCFS. If you don't have a sensible 2D...

For the use case of wanting to evaluate a function $f(\psi(r, z))$ at an arbitrary point in space, with no special treatment of the separatrix as a boundary between closed...

I did consider whether it was worthwhile making these sparse matrices when first implementing those utilities (which were initially copied from demo functionality scripts where optimisation was very much not...

Hi @wave46. The `cherab.core.model.TotalRadiatedPower` model is the one you want. For each species (element, charge) it outputs the sum of the line radiation and recombination. You'll need to add a...

Thanks for the proposal @je-cook. Certainly worth further discussion. A couple of points: > As I understand it from a conversation with Carine the reason for the original combining was...