core icon indicating copy to clipboard operation
core copied to clipboard

Precalculate bi/tri-cubic coefficient inverse in cubic interpolators

Open CnlPepper opened this issue 7 years ago • 1 comments

The current cubic interpolators are unnecessarily re-inverting the coefficient matrix for each cell. This can be precomputed. This would also improve the numerical accuracy of (beyond 5-6 decimal place) by avoiding an unnecessary pre/post normalisation that occurs around the inversion.

CnlPepper avatar Nov 08 '18 13:11 CnlPepper

We now recommend the use of Raysect's interpolators, which don't have this issue. All internal uses of the interpolators in Cherab were swapped to Raysect ones in #304. The existing interpolators have been marked as deprecated and retained only for backwards compatibility.

The other place this issue appears is in the caching objects. These are being re-written in #363.

jacklovell avatar Dec 22 '22 17:12 jacklovell